Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add release notes for 0.1.0 #647

Merged
merged 11 commits into from
Jul 23, 2024

Conversation

jashapiro
Copy link
Member

As I was preparing #623, I thought it might be nice to have the release notes reviewed, which let me to wanting to create a changelog file to hold them all.

Please review these initial release notes, and let me know if there is anything you think I should specifically add or generally rephrase.

I also made a few updates fixing paths in templates that I noticed had changed and a few other minor template updates.

Copy link
Member

@allyhawkins allyhawkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is fine, I just had one suggestion about including a link to the actual docs page, but up to you.

CHANGELOG.md Outdated

With respect to infrastructure, the repository contains the following components:

- detailed documentation in the `docs` directory explaining how to interact with the OpenScPCA project and how to set up and run analyses
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe provide a link to the actual docs too?

RELEASE_NOTES.md Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we also have this file? What am I missing?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had named it that before. Not sure how it got duplicated rather than renamed!

@jashapiro
Copy link
Member Author

Okay, I removed the extra file, added the link @allyhawkins requested, and then decided that we should probably keep these root-level .md files spellchecked, so I added that pattern to the spellcheck action. Amazingly enough*, I didn't have any spelling errors, only module names that needed quoting.

*I run typos locally, so not that amazing.

@jashapiro jashapiro requested a review from jaclyn-taroni July 23, 2024 19:19
Copy link
Member

@jaclyn-taroni jaclyn-taroni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

@jashapiro jashapiro merged commit 79786c5 into AlexsLemonade:main Jul 23, 2024
3 checks passed
@jashapiro jashapiro deleted the jashapiro/prep0.1.0 branch July 23, 2024 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants