Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

try to catch copykat error #966

Merged
merged 1 commit into from
Dec 22, 2024
Merged

try to catch copykat error #966

merged 1 commit into from
Dec 22, 2024

Conversation

jashapiro
Copy link
Member

I couldn't resist trying to fix #965 with a quick error catch. Let's see if this works.

@jashapiro
Copy link
Member Author

Well it seemed to work, and the downstream steps already had tryCatch() statements to account for copykat failure, so maybe this is worth including.

@jashapiro jashapiro marked this pull request as ready for review December 21, 2024 01:40
jaclyn-taroni
jaclyn-taroni approved these changes Dec 22, 2024
View reviewed changes
Copy link
Member

@jaclyn-taroni jaclyn-taroni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

@jashapiro jashapiro merged commit 82a2f65 into AlexsLemonade:main Dec 22, 2024
3 checks passed
@jashapiro jashapiro deleted the jashapiro/copykatch branch December 22, 2024 21:40
@jashapiro jashapiro mentioned this pull request Dec 23, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaclyn-taroni jaclyn-taroni jaclyn-taroni approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Analysis module failing in CI
2 participants
@jashapiro @jaclyn-taroni