Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bluesky to OpenScPCA footer #989

Merged
merged 2 commits into from
Jan 16, 2025
Merged

Conversation

Jen-OMalley
Copy link
Collaborator

@Jen-OMalley Jen-OMalley commented Jan 15, 2025

Purpose/implementation Section

I am adding our new Bluesky account to the OpenScPCA website footer. (I deleted most of the instructions in this template since it's not that kind of contribution!)

Please link to the GitHub issue that this pull request addresses.

This PR addresses #986.

What is the goal of this pull request?

See above!

Provide directions for reviewers

I'm not sure if there was more to do beyond editing the social section in mkdocs.yml. Let me know if more steps are required for this! (I think it's fine if only @dvenprasad reviews this.)

Copy link
Member

@dvenprasad dvenprasad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🦋 🦋 🦋

@Jen-OMalley
Copy link
Collaborator Author

Thank you @dvenprasad! Merging is currently blocked. Do you know if both code owners must review every PR? (I don't think I have filed one in this repo for quite awhile!) If not, maybe I need to re-request you to approve this.

@jaclyn-taroni
Copy link
Member

Deepa did not actually approve, just commented – that was the issue. I've now approved.

@Jen-OMalley
Copy link
Collaborator Author

Ah ok! Thank you!

@Jen-OMalley Jen-OMalley merged commit 0448862 into main Jan 16, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants