Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docstrings for InterTypes #100

Merged
merged 5 commits into from
Jan 24, 2024
Merged

Docstrings for InterTypes #100

merged 5 commits into from
Jan 24, 2024

Conversation

olynch
Copy link
Member

@olynch olynch commented Jan 23, 2024

Addresses #99

Copy link

codecov bot commented Jan 23, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (3e93d2e) 90.61% compared to head (01ff30d) 90.80%.

Files Patch % Lines
src/intertypes/json.jl 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #100      +/-   ##
==========================================
+ Coverage   90.61%   90.80%   +0.18%     
==========================================
  Files          22       22              
  Lines        2110     2109       -1     
==========================================
+ Hits         1912     1915       +3     
+ Misses        198      194       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@epatters epatters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for writing these docs.

@olynch olynch merged commit 3c958fc into main Jan 24, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants