Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't export generators function #72

Merged
merged 1 commit into from
Oct 13, 2023
Merged

Don't export generators function #72

merged 1 commit into from
Oct 13, 2023

Conversation

kris-brown
Copy link
Collaborator

Catlab also defines generators but isn't in a position right now to make a new release, so temporarily we will not export this to avoid creating an ambiguous name.

@kris-brown kris-brown self-assigned this Oct 13, 2023
@kris-brown kris-brown requested a review from epatters October 13, 2023 23:29
@kris-brown kris-brown added the bug Something isn't working label Oct 13, 2023
@codecov
Copy link

codecov bot commented Oct 13, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (9050430) 91.70% compared to head (2487088) 91.77%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #72      +/-   ##
==========================================
+ Coverage   91.70%   91.77%   +0.07%     
==========================================
  Files          17       17              
  Lines        1362     1362              
==========================================
+ Hits         1249     1250       +1     
+ Misses        113      112       -1     
Files Coverage Δ
src/NautyInterface.jl 98.05% <ø> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@epatters epatters changed the title don't export generators Don't export generators function Oct 13, 2023
@epatters epatters merged commit 793a205 into main Oct 13, 2023
9 checks passed
@epatters epatters deleted the hidegens branch October 13, 2023 23:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants