Floating viewer for Graphviz output #947
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
epatters
reviewed
Oct 23, 2024
epatters
reviewed
Oct 23, 2024
epatters
reviewed
Oct 23, 2024
epatters
requested changes
Oct 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since I mainly use Vim to develop, I don't have an embedded file viewer like VSCode so I wrote this snippet to visualize graphs in a floating window. But I'm opening this draft PR to open the discussion whether it should be upstreamed, and if so, what technical considerations.
I'm aware that
isdefined(Main, :VSCodeServer)allows us to check if the REPL is being run in VSCode (and likewise for Juypter and IJulia), but I didn't write a validation to check that as I assumed a user would call this function in order to visualize the graph in a floating window.runstatements be used in code?fehfor example is not an image viewer everyone uses.