Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Many bugs in the code. #52

Open
ootts opened this issue Jan 24, 2024 · 2 comments
Open

Many bugs in the code. #52

ootts opened this issue Jan 24, 2024 · 2 comments

Comments

@ootts
Copy link

ootts commented Jan 24, 2024

Hi, I find your code very helpful in reproducing NNRT+Fusion. However, when I run "python run_fusion.py", there are lots of errors raised. I am wondering if I am running the correct version of your code. I am using the main branch, the latest commit.
The errors include but not limited:

  1. Parameter has no attribute index. Currently I change the .index to .value.
  2. graph_for_integration is not defined.
  3. here should be "color".
  4. here warped_mesh is not defined.

Please kindly guide me to run it successfully! Thanks!

@Leeffkk
Copy link

Leeffkk commented Jan 29, 2024

Hello @ootts , I've also been working with this repo.

Another issue I met while running "run_fusion.py" is that the "apps/create_graph_data.py" calls the GraphWarpField() function.
In python codes, the function takes 4 parameters: (nodes, edges, edge_weights, clusters).

However, currently the GraphWarpField() function is binded to "HierarchicalGraphWarpField.h" that only takes nodes in it's constructor.

Thus, whenever GraphWarpField() is called in python code, an error is thrown.

I'm guessing that it is supposed to be binded to "PlanarGraphWarpFields.h", which takes (nodes, edges, edge_weights, clusters).

Please let me know if you have resolved this issue

@ootts
Copy link
Author

ootts commented Jan 29, 2024

@Leeffkk Hi, I also met this issue. I skipped this issue by returning the edges, edge_weights, and clusters separately. The GraphWarpField class is kept as only taking nodes as member variables.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants