Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: package-name was not a valid EIP-2678 package-name #119

Merged
merged 1 commit into from
Jan 10, 2025

Conversation

antazoey
Copy link
Member

@antazoey antazoey commented Jan 9, 2025

What I did

EIP-2678 says "ApePay" is an invalid package name because of the upper case letters.

How I did it

How to verify it

Checklist

  • All changes are completed
  • Change is covered in tests
  • Documentation is complete

@antazoey antazoey requested a review from fubuloubu January 10, 2025 00:06
@fubuloubu fubuloubu merged commit 5d971c9 into main Jan 10, 2025
8 checks passed
@fubuloubu fubuloubu deleted the fix/package-name branch January 10, 2025 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants