refactor: make isCancellable sync [SBK-370] #78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vany365
changed the title
SBK-370 "Refacto/ make isCancellable sync" (ApeWorX/ApePay #78)
isCancellable used to be async; we displayed 'fetching remaining time...' while waiting for the promise to return, which would take ~5-10 secs. I added the startTime in the Stream constructor to make it sync. Now there is little to no loading time in the cancel stream component, which is a great UX win. It allows to display the remaining time almost instantly when you load the stream. ApeWorX/ApePay #78 by alexisnsns on GitHub via LinearSync |
|
Also changed the wording to add 'simulations' and edited the css of the cancel button to make it so that on the demo app the user knows when a button is disabled |
Also finally added a favicon: it's one less error to deal with, which makes the console cleaner and debugging easier. |
fubuloubu
changed the title
fubuloubu
approved these changes
Nov 22, 2023
fubuloubu
approved these changes
Nov 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
isCancellable used to be async, with the cancel component displaying a loading message while waiting for the promise to resolve, which would take ~5-10 secs.
I added the startTime in the Stream constructor to make it sync.
Now there is little to no loading time in the cancel stream component, which is a great UX win.
It allows to display the remaining time almost instantly when you load the stream.