Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add websocket support for arbitrum and optimism #71

Merged
merged 1 commit into from
Feb 16, 2024
Merged

feat: add websocket support for arbitrum and optimism #71

merged 1 commit into from
Feb 16, 2024

Conversation

fubuloubu
Copy link
Member

What I did

fixes: #

How I did it

How to verify it

Checklist

  • Passes all linting checks (pre-commit and CI jobs)
  • New test cases have been added and are passing
  • Documentation has been updated
  • PR title follows Conventional Commit standard (will be automatically included in the changelog)

@fubuloubu fubuloubu requested a review from antazoey February 16, 2024 18:09
antazoey
antazoey approved these changes Feb 16, 2024
View reviewed changes
Copy link
Member

@antazoey antazoey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm, could consider mentioning it's still beta for arb and opt, but maybe not worth it

@fubuloubu
Copy link
Member Author

Lgtm, could consider mentioning it's still beta for arb and opt, but maybe not worth it

I think it just means the pricing could change

@fubuloubu fubuloubu merged commit 2d9ff00 into main Feb 16, 2024
22 checks passed
@fubuloubu fubuloubu deleted the feat/arb-opt-websockets branch February 16, 2024 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antazoey antazoey antazoey approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fubuloubu @antazoey