Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor!: remove goerli network from arbitrum and optimism #74

Merged
merged 1 commit into from
Mar 28, 2024

Conversation

derekpierre
Copy link
Contributor

@derekpierre derekpierre commented Mar 28, 2024

What I did

fixes: #73

BREAKING CHANGE: "goerli" no longer a valid value for arbitrum or optimism.

How I did it

Removed "goerli" entries for arbitrum and optimism. The tests fail otherwise.

How to verify it

Checklist

  • Passes all linting checks (pre-commit and CI jobs)
  • New test cases have been added and are passing
  • Documentation has been updated
  • PR title follows Conventional Commit standard (will be automatically included in the changelog)

@fubuloubu fubuloubu changed the title feat!: Remove goerli values from arbitrum and optimism since no longer supported by Infura refactor!: remove goerli network from arbitrum and optimism as no longer supported Mar 28, 2024
@fubuloubu fubuloubu changed the title refactor!: remove goerli network from arbitrum and optimism as no longer supported refactor!: remove goerli network from arbitrum and optimism Mar 28, 2024
@fubuloubu fubuloubu merged commit 6e771a7 into ApeWorX:main Mar 28, 2024
7 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deprecate goerli for arbitrum and optimism since no longer supported by Infura
2 participants