Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: missing transaction during return value check imp acct #5

Merged
merged 3 commits into from
Jan 9, 2025
Merged

fix: missing transaction during return value check imp acct #5

merged 3 commits into from
Jan 9, 2025

Conversation

antazoey
Copy link
Member

@antazoey antazoey commented Jan 8, 2025

What I did

fixes: #

How I did it

How to verify it

Checklist

  • Passes all linting checks (pre-commit and CI jobs)
  • New test cases have been added and are passing
  • Documentation has been updated
  • PR title follows Conventional Commit standard (will be automatically included in the changelog)

@antazoey antazoey mentioned this pull request Jan 8, 2025
Closed
4 tasks
bitwise-constructs
bitwise-constructs approved these changes Jan 8, 2025
View reviewed changes
Copy link

@bitwise-constructs bitwise-constructs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Woo eth_pydantic_types representation

@antazoey
Copy link
Member Author

antazoey commented Jan 8, 2025

Woo eth_pydantic_types representation

ya, I may eventually request for a better API for __eth_pydantic_validate__, it feels a bit too internal

@antazoey
Copy link
Member Author

antazoey commented Jan 8, 2025

I am having some issues with fork mode hanging in boa during py_evm.deploy_code(), talking to Charles about it.

@antazoey antazoey merged commit 5ec0647 into main Jan 9, 2025
12 of 14 checks passed
@antazoey antazoey deleted the fix/missing-tx branch January 9, 2025 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fubuloubu fubuloubu fubuloubu approved these changes

@bitwise-constructs bitwise-constructs bitwise-constructs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@antazoey @bitwise-constructs @fubuloubu