Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: update cached compilers improvements [APE-1500] #1721

Merged
merged 20 commits into from
Dec 16, 2023

Conversation

antazoey
Copy link
Member

@antazoey antazoey commented Nov 2, 2023

What I did

  • Allows easily updating the project manifest cache.
  • Allows CompilerAPI to add the compiler ethpm classes and acknowledges those (more secure and accurate to use the settings actually used when doing verification)

How I did it

  • Create method for updating it and share some stuff
  • Refactor: general breaking change improvements that shouldnt really matter
  • feat: honor compilers output

Checklist

  • All changes are completed
  • New test cases have been added
  • Documentation has been updated

@vany365 vany365 changed the title feat: update cache method feat: update cache method [APE-1500] Nov 2, 2023
@antazoey antazoey force-pushed the feat/easily-update-compilers branch from 7bbbd0a to da650ab Compare November 2, 2023 18:08
@antazoey antazoey marked this pull request as draft November 2, 2023 18:21
@antazoey antazoey force-pushed the feat/easily-update-compilers branch from da650ab to 4b77870 Compare November 2, 2023 19:58
Copy link

github-actions bot commented Dec 3, 2023

This pull request is considered stale because it has been open 30 days with no activity. Remove stale label, add a comment, or make a new commit, otherwise this PR will be closed in 5 days.

@github-actions github-actions bot added the stale No activity for 30 days label Dec 3, 2023
@fubuloubu fubuloubu removed the stale No activity for 30 days label Dec 4, 2023
@antazoey
Copy link
Member Author

ok i may actually need this now... trying to fix etherscan verification

@antazoey antazoey force-pushed the feat/easily-update-compilers branch from 66cce20 to 3f2d437 Compare December 14, 2023 06:36
@antazoey
Copy link
Member Author

required ApeWorX/ethpm-types#103

@antazoey antazoey force-pushed the feat/easily-update-compilers branch 3 times, most recently from cef13a6 to c11ba05 Compare December 14, 2023 16:32
@antazoey antazoey force-pushed the feat/easily-update-compilers branch from c11ba05 to eb736a8 Compare December 14, 2023 16:45
@antazoey antazoey force-pushed the feat/easily-update-compilers branch from d290e6c to 4e8e45e Compare December 14, 2023 17:47
@antazoey antazoey marked this pull request as ready for review December 14, 2023 18:30
@antazoey antazoey enabled auto-merge (squash) December 14, 2023 19:12
@antazoey antazoey changed the title feat: update cache method [APE-1500] feat: update cached compilers improvements [APE-1500] Dec 14, 2023
@antazoey antazoey changed the title feat: update cached compilers improvements [APE-1500] feat!: update cached compilers improvements [APE-1500] Dec 14, 2023
@antazoey antazoey disabled auto-merge December 14, 2023 19:54
@antazoey antazoey force-pushed the feat/easily-update-compilers branch from b337b77 to 12c9704 Compare December 14, 2023 20:16
fubuloubu
fubuloubu previously approved these changes Dec 14, 2023
@antazoey antazoey enabled auto-merge (squash) December 14, 2023 20:23
@antazoey
Copy link
Member Author

now, i have compilers being output in ape-solidity and about to make sure is being used in ape-etherscan.
maybe it won't fix our verification bug, maybe it will... but in any case, the settings are 100% more honest now and i think that is a huge win.

still need to do same in ape-vyper pr

@antazoey antazoey merged commit e6821c3 into ApeWorX:main Dec 16, 2023
15 checks passed
@antazoey antazoey deleted the feat/easily-update-compilers branch December 16, 2023 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants