chore: pr feedback

ApeWorX · Nov 4, 2023 · 912685a · 912685a
1 parent 67c6aed
commit 912685a
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 8 deletions.
diff --git a/ethpm_types/manifest.py b/ethpm_types/manifest.py
@@ -280,7 +280,7 @@ def get_contract_compiler(self, contract_type_name: str) -> Optional[Compiler]:
 
         return None
 
-    def update_compilers(self, compilers: List[Compiler]):
+    def add_compilers(self, *compilers: List[Compiler]):
         """
         Update compilers in the manifest. This method appends any
         given compiler with a a different name, version, and settings
@@ -291,9 +291,9 @@ def update_compilers(self, compilers: List[Compiler]):
               compilers.
         """
 
-        updated_compilers = [*compilers]
-        for prior_compiler in self.compilers or []:
-            if prior_compiler not in updated_compilers:
-                updated_compilers.append(prior_compiler)
+        if self.compilers is None:
+            self.compilers = []
 
-        self.compilers = updated_compilers
+        for compiler in compilers:
+            if compiler not in self.compilers:
+                self.compilers.append(compiler)
diff --git a/tests/test_package_manifest.py b/tests/test_package_manifest.py
@@ -133,7 +133,7 @@ def test_get_contract_compiler():
     assert manifest.get_contract_compiler("yoyoyo") is None
 
 
-def test_update_compilers():
+def test_add_compilers():
     compiler = Compiler(name="vyper", version="0.3.7", settings={}, contractTypes=["foobar"])
     manifest = PackageManifest(
         compilers=[compiler],
@@ -146,7 +146,7 @@ def test_update_compilers():
         Compiler(name="vyper", version="0.3.7", settings={}, contractTypes=["foobar", "testtest"]),
         Compiler(name="vyper", version="0.3.10", settings={}, contractTypes=["yoyo"]),
     ]
-    manifest.update_compilers(new_compilers)
+    manifest.update_compilers(*new_compilers)
     assert len(manifest.compilers) == 2