Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Support pydantic 2.10 #144

Merged
merged 3 commits into from
Nov 21, 2024
Merged

feat: Support pydantic 2.10 #144

merged 3 commits into from
Nov 21, 2024

Conversation

antazoey
Copy link
Member

What I did

Was not working on pydantic 2.10 because of a URL change they made! 😲

How I did it

Have to use our own AnyUrl that includes File

How to verify it

Checklist

  • Passes all linting checks (pre-commit and CI jobs)
  • New test cases have been added and are passing
  • Documentation has been updated
  • PR title follows Conventional Commit standard (will be automatically included in the changelog)

antazoey
antazoey commented Nov 21, 2024
View reviewed changes
ethpm_types/utils.py

from eth_pydantic_types import HexStr

CONTENT_ADDRESSED_SCHEMES = {"ipfs"}
AnyUrl = Union[FileUrl, _AnyUrl]
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is the ugh

@antazoey antazoey requested a review from dtdang November 21, 2024 18:08
@antazoey antazoey merged commit db2aada into ApeWorX:main Nov 21, 2024
16 checks passed
@antazoey antazoey deleted the chore/update-pydantic branch November 21, 2024 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dtdang dtdang dtdang approved these changes

@bitwise-constructs bitwise-constructs Awaiting requested review from bitwise-constructs

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@antazoey @dtdang