Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: initial config for Ronin network #20

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

bitwise-constructs
Copy link
Contributor

What I did

Adds the Ronin network to chains

Checklist

  • All changes are completed
  • New test cases have been added
  • Documentation has been updated

@bitwise-constructs
Copy link
Contributor Author

@mikeshultz realizing there's a script for this.. will update the PR with the generated config later this morning

@bitwise-constructs
Copy link
Contributor Author

dependent on ethereum-lists/chains#3219 to correct 2020 chain ID

@antazoey antazoey marked this pull request as ready for review December 16, 2024 22:06
@antazoey antazoey marked this pull request as draft December 16, 2024 22:06
README.md Outdated Show resolved Hide resolved
@@ -1115,6 +1115,7 @@
"https://sepolia.gateway.tenderly.co",
"https://ethereum-sepolia-rpc.publicnode.com",
"https://sepolia.drpc.org",
"https://eth-sepolia.g.alchemy.com/v2/WddzdzI2o9S3COdT73d5w6AIogbKq4X-",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lol weird there would be one with an API in key...

@@ -2242,6 +2243,64 @@
"slip44": None,
},
},
"ronin": {
"mainnet": {
"chain": "PublicMint",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wow this is the first time we have had a clashing of chain IDs... weird

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants