Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: replace is_crate_type_lib by filter_crate_type to support extra crate-types #67

Merged
merged 2 commits into from
Oct 26, 2024

Conversation

zjp-CN
Copy link
Contributor

@zjp-CN zjp-CN commented Oct 26, 2024

so far, the following usages on cargo-rap are tested:

export RAP_LOG=warn

# os-checker-test-suite/workspace2
# cargo rap -F -M -- -p # list Possible packages/workspace members
cargo rap -F -M -- -p ws-rap-checks-this1
cargo rap -F -M -- -p ws-rap-checks-this2
cargo rap -F -M -- --workspace

# check with feature selection
cargo rap -F -M -- -p ws-rap-checks-this_with-feature-gated -F rap

# check packages (build.rs is not detected by rap, but directly handled by rustc)
cargo rap -F -M -- -p ws-rap-checks-this_with-build-script

# check tests & examples
cargo rap -F -M -- -p ws-rap-checks-test-and-example --examples --tests
cd crates/ws-rap-checks-test-and-example
cargo rap -F -M -- --example ex1
cargo rap -F -M -- --examples
cargo rap -F -M -- --tests
cargo rap -F -M -- --examples --tests

see https://github.com/os-checker/os-checker-test-suite/tree/main/workspace2

…crate-types

so far, the following usages on cargo-rap are tested:

```bash
export RAP_LOG=warn

\# os-checker-test-suite/workspace2
\# cargo rap -F -M -- -p # list Possible packages/workspace members
cargo rap -F -M -- -p ws-rap-checks-this1
cargo rap -F -M -- -p ws-rap-checks-this2
cargo rap -F -M -- --workspace

\# check with feature selection
cargo rap -F -M -- -p ws-rap-checks-this_with-feature-gated -F rap

\# check packages (build.rs is not detected by rap, but directly handled by rustc)
cargo rap -F -M -- -p ws-rap-checks-this_with-build-script

\# check tests & examples
cargo rap -F -M -- -p ws-rap-checks-test-and-example --examples --tests
cd crates/ws-rap-checks-test-and-example
cargo rap -F -M -- --example ex1
cargo rap -F -M -- --examples
cargo rap -F -M -- --tests
cargo rap -F -M -- --examples --tests
```

see https://github.com/os-checker/os-checker-test-suite/tree/main/workspace2
@hxuhack hxuhack merged commit 3d2e8a0 into Artisan-Lab:main Oct 26, 2024
1 check passed
@zjp-CN zjp-CN deleted the fix/cc-error branch October 26, 2024 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants