Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: todos in datagraph and nodeop replacement bug #92

Merged
merged 3 commits into from
Jan 12, 2025

Conversation

Unparalleled-Calvin
Copy link
Contributor

  • Some match arms in datagraph have been implemented now to avoid panic
  • Change the basic field op in the GraphNode.
    • Previously, our datagraph was build upon a hypothesis that every Local in MIR should be assigned for once and only once.
    • While actually we found that a Local can be assigned for multiple times. Thus I added the seq marker in edges to differentiate between edges.
    • However, the nodeop also needs to save the previous one and keep every record available.
    • In this PR, the op field is replaced by ops which is a Vec<NodeOp> and corresponding codes are also revised.

@hxuhack hxuhack merged commit ddd4cc5 into Artisan-Lab:main Jan 12, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants