generated from emilk/eframe_template
-
-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tilemap optimizations #132
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Splits viewport into a transform and screen size - Fundamentally changes how things are drawn - Ditches Arc everywhere, so now there are practically 0 multithreading primitives - Breaks things
white-axe
requested changes
Jun 15, 2024
white-axe
requested changes
Jun 16, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I get this panic message when using the web build with WebGL in both Chromium and Firefox:
The application panicked (crashed).
Message: wgpu error: Validation Error
Caused by:
In Device::create_render_pipeline
note: label = `Tilemap Sprite Render Pipeline`
In the provided shader, the type given for group 0 binding 2 has a size of 24. As the device does not support `DownlevelFlags::BUFFER_BINDINGS_NOT_16_BYTE_ALIGNED`, the type must have a size that is a multiple of 16 bytes.
Location: /home/h/.cargo/registry/src/index.crates.io-6f17d22bba15001f/wgpu-0.19.1/src/backend/wgpu_core.rs:3009
Luminol version: d6d5041e
Backtrace omitted. Run with RUST_BACKTRACE=1 environment variable to display it.
Run with RUST_BACKTRACE=full to include source snippets.
white-axe
reviewed
Jun 16, 2024
Weird, I don't get this panic. Should be an easy fix though! |
white-axe
approved these changes
Jun 16, 2024
MolassesLover
pushed a commit
to MolassesLover/luminol-molasses
that referenced
this pull request
Jul 23, 2024
* Use the layout from the old branch * Remove support for push constants * Use bytes_of and from_bytes * Use vec2 instead of vec3 * Move grid.wgsl * Don't use an instance buffer for the grid * Move the tilepicker mostly into graphics * Fix collision shader * Remove vertex buffer from grid * Remove tilemap vertex buffer * Remove vertex buffer from collision * Use shared placeholder png * Update alox-48 * Massively refactor things (still broken) - Splits viewport into a transform and screen size - Fundamentally changes how things are drawn - Ditches Arc everywhere, so now there are practically 0 multithreading primitives - Breaks things * Fix event position bug * Actually render the grid * Fix viewport translations * Fix autotile animation * Fix some grid issues * Reimplement event preview * Fix collision * Fix align bug * Fix event preview rendering * Fix some webgl issues
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connections
#98
#102
Description
This PR overhauls how the tilemap and its components are rendered and used.
AtomicCell
have been removedTesting
Open maps, move events around, hover over events to display them
Checklist
cargo fmt
.cargo clippy
. If applicable, add:--target wasm32-unknown-unknown -Z build-std=std,panic_abort
cargo build --release
trunk build --release