Skip to content

Commit

Permalink
Charts: Fix direct import from cjs & rollup config cleanup (#41266)
Browse files Browse the repository at this point in the history
* we should not import from @visx/*/lib which is cjs module - we can only import types from there

* simplify rollup config

* simplify rollup config

* remove fixup bash

* changelog

* no need to set file name

Committed via a GitHub action: https://github.com/Automattic/jetpack/actions/runs/12918628281

Upstream-Ref: Automattic/jetpack@7cbc956
  • Loading branch information
kangzj authored and matticbot committed Jan 22, 2025
1 parent 0022312 commit 4294142
Show file tree
Hide file tree
Showing 135 changed files with 152 additions and 1,877 deletions.
7 changes: 5 additions & 2 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,10 +5,13 @@ All notable changes to this project will be documented in this file.
The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/)
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).

## [0.4.1-alpha] - unreleased
## [0.5.0-alpha] - unreleased

This is an alpha version! The changes listed here are not final.

### Changed
- Simplify rollup config and remove a cjs import

## [0.4.0] - 2025-01-22
### Added
- Added passing through options for X, Y axis [#41109]
Expand Down Expand Up @@ -71,7 +74,7 @@ This is an alpha version! The changes listed here are not final.
- Fixed lints following ESLint rule changes for TS [#40584]
- Fixing a bug in Chart storybook data. [#40640]

[0.4.1-alpha]: https://github.com/Automattic/charts/compare/v0.4.0...v0.4.1-alpha
[0.5.0-alpha]: https://github.com/Automattic/charts/compare/v0.4.0...v0.5.0-alpha
[0.4.0]: https://github.com/Automattic/charts/compare/v0.3.0...v0.4.0
[0.3.0]: https://github.com/Automattic/charts/compare/v0.2.3...v0.3.0
[0.2.3]: https://github.com/Automattic/charts/compare/v0.2.2...v0.2.3
Expand Down
2 changes: 2 additions & 0 deletions dist/cjs/components/bar-chart/bar-chart.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions dist/cjs/components/bar-chart/bar-chart.js.map

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 2 additions & 0 deletions dist/cjs/components/bar-chart/bar-chart.module.scss.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions dist/cjs/components/bar-chart/bar-chart.module.scss.js.map

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 0 additions & 2 deletions dist/cjs/components/bar-chart/index.js

This file was deleted.

1 change: 0 additions & 1 deletion dist/cjs/components/bar-chart/index.js.map

This file was deleted.

Loading

0 comments on commit 4294142

Please sign in to comment.