Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Remove Listening History Button #3471

Open
wants to merge 3 commits into
base: release/7.81
Choose a base branch
from

Conversation

mebarbosa
Copy link
Contributor

@mebarbosa mebarbosa commented Jan 21, 2025

Description

Testing Instructions

  • Smoke test the remove individual listening history
  • ✅ Ensure this button displays only for when the user played the episode
  • ✅ Ensure this button is not available for when the user favorited / downloaded an episode without playing it

Checklist

  • If this is a user-facing change, I have added an entry in CHANGELOG.md
  • Ensure the linter passes (./gradlew spotlessApply to automatically apply formatting/linting)
  • I have considered whether it makes sense to add tests for my changes
  • All strings that need to be localized are in modules/services/localization/src/main/res/values/strings.xml
  • Any jetpack compose components I added or changed are covered by compose previews
  • I have updated (or requested that someone edit) the spreadsheet to reflect any new or changed analytics.

@mebarbosa mebarbosa added [Type] Bug Not functioning as intended. [Area] Episode Row labels Jan 21, 2025
@mebarbosa mebarbosa added this to the 7.81 ❄️ milestone Jan 21, 2025
@mebarbosa mebarbosa requested a review from a team as a code owner January 21, 2025 19:16
@mebarbosa mebarbosa requested review from geekygecko and removed request for a team January 21, 2025 19:16
@dangermattic
Copy link
Collaborator

1 Warning
⚠️ This PR is assigned to the milestone 7.81 ❄️. The due date for this milestone has already passed.
Please assign it to a milestone with a later deadline or check whether the release for this milestone has already been finished.

Generated by 🚫 Danger

@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Jan 21, 2025

📲 You can test the changes from this Pull Request in 📱 Mobile by scanning the QR code below to install the corresponding build.
App Name 📱 Mobile
Build TypedebugProd
Commit3571bea
Direct Downloadpocketcasts-app-prototype-build-pr3471-3571bea.apk
📲 You can test the changes from this Pull Request in 🚗 Automotive by scanning the QR code below to install the corresponding build.
App Name 🚗 Automotive
Build TypedebugProd
Commit3571bea
Direct Downloadpocketcasts-automotive-prototype-build-pr3471-3571bea.apk
📲 You can test the changes from this Pull Request in ⌚ Wear by scanning the QR code below to install the corresponding build.
App Name ⌚ Wear
Build TypedebugProd
Commit3571bea
Direct Downloadpocketcasts-wear-prototype-build-pr3471-3571bea.apk

@geekygecko
Copy link
Member

Should the "Remove from history" button be on pages other than the "Listening History"? If I star an episode that's in my listening history and then open the starred page I can see the option when I multi-select.

Screenshot_20250122_151434 Screenshot_20250122_151450

@mebarbosa
Copy link
Contributor Author

Should the "Remove from history" button be on pages other than the "Listening History"? If I star an episode that's in my listening history and then open the starred page I can see the option when I multi-select.

@geekygecko I don't mind to change this, but I applied the same behavior that we implemented for the other buttons. For example, if I download an episode I can see the star option in downloads screen

@geekygecko
Copy link
Member

geekygecko commented Jan 23, 2025

I don't mind to change this, but I applied the same behavior that we implemented for the other buttons. For example, if I download an episode I can see the star option in downloads screen

It doesn't feel the same having the remove from history on the other screens. For example, this is the Web Player, it only has the action on the listening history page. I think it might be best for us to ask the product team. p1737593296509329-slack-C05RR9P9RAT

Screenshot 2025-01-23 at 11 14 39 am Screenshot 2025-01-23 at 11 14 48 am

@CookieyedCodes
Copy link

It could also be a swipe icon instead of archive just a proposal tho :)

Screenshot_2025-01-23-10-22-49-74_28ad70af3b47247953fcd94176b9a9c1.jpg

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Area] Episode Row [Type] Bug Not functioning as intended.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants