You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR is assigned to the milestone 7.81 ❄️. The due date for this milestone has already passed.
Please assign it to a milestone with a later deadline or check whether the release for this milestone has already been finished.
Should the "Remove from history" button be on pages other than the "Listening History"? If I star an episode that's in my listening history and then open the starred page I can see the option when I multi-select.
Should the "Remove from history" button be on pages other than the "Listening History"? If I star an episode that's in my listening history and then open the starred page I can see the option when I multi-select.
@geekygecko I don't mind to change this, but I applied the same behavior that we implemented for the other buttons. For example, if I download an episode I can see the star option in downloads screen
I don't mind to change this, but I applied the same behavior that we implemented for the other buttons. For example, if I download an episode I can see the star option in downloads screen
It doesn't feel the same having the remove from history on the other screens. For example, this is the Web Player, it only has the action on the listening history page. I think it might be best for us to ask the product team. p1737593296509329-slack-C05RR9P9RAT
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
main
branch #3453 (comment)Testing Instructions
Checklist
./gradlew spotlessApply
to automatically apply formatting/linting)modules/services/localization/src/main/res/values/strings.xml