E2E Playwright Migration: convert Order Partial Refund spec #10194
+223
−212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test the buildOption 1. Jetpack Beta
Option 2. Jurassic Ninja - available for logged-in A12s🚀 Launch a JN site with this branch 🚀 ℹ️ Install this Tampermonkey script to get more options. Build info:
Note: the build is updated when a new commit is pushed to this PR. |
|
Size Change: 0 B Total Size: 1.36 MB ℹ️ View Unchanged
|
Add restoreCurrencies Update shopper and merchant vars
Implement test loop
tpaksu
requested changes
Jan 22, 2025
There was a problem hiding this comment.
Thanks for working on this, I guess this is still a WIP, as it is missing most of the verifications of the updated rows, refund block, and the partial refund note added after the refund operation. Let me know if skipping those were intentional, but I'm more inclined that those should be included in the PR.
tests/e2e-pw/specs/merchant/merchant-orders-partial-refund.spec.ts
Outdated
Show resolved
Hide resolved
| } | ||
| } ); | ||
|
|
||
| for ( let i = 0; i < dataTable.length; i++ ) { |
There was a problem hiding this comment.
Nitpick: You can use this for accessing the elements in the dataTable easily:
Object.entries(dataTable).forEach(([title, { lineItems, refundInputs }]) => {There was a problem hiding this comment.
Thanks for this suggestion. I wasn't able to implement it exactly this way. I also need the i for targeting the correct orderId from the orderIds array. I took a similar approach in f68aa46.
There was a problem hiding this comment.
You could get the index with:
Object.entries(dataTable).forEach(([title, { lineItems, refundInputs }], i) => {There was a problem hiding this comment.
Yea, I got the index with the i like that, but Typescript doesn't like when I use Object.entries(dataTable).forEach instead of just dataTable.forEach. If I use your suggestion, I get:
Property 'refundInputs' does not exist on type '[string, { lineItems: [string, number][]; refundInputs: { refundQty: number; refundAmount: number; }[]; }]'.ts(2339)
I don't get it with lineItems b/c I remove them since they aren't used in the test, only in the beforeAll setup. If I add them back, I also get the Typescript warning about them not existing on the dataTable type.
dataTable.forEach is working well though, so I think we can stick with it.
tests/e2e-pw/specs/merchant/merchant-orders-partial-refund.spec.ts
Outdated
Show resolved
Hide resolved
tests/e2e-pw/specs/merchant/merchant-orders-partial-refund.spec.ts
Outdated
Show resolved
Hide resolved
Thanks for the review, Taha! Skipping those was not intentional. I must have just missed them when converting the spec. I'll double check it and get those added. I'll re-request a review once that is done. |
Add comments for clarity
|
@tpaksu, I've addressed your feedback, and I think I've covered all the refund line items, order notes, etc checks after the refund is processed that I missed the first time around. Could you give this one another review when you have a moment? |
tpaksu
reviewed
Jan 23, 2025
| .nth( j ) | ||
| .fill( refundAmount.toString() ); | ||
|
|
||
| await merchantPage.keyboard.press( 'Tab' ); |
There was a problem hiding this comment.
Not an issue but out of curiousity, why do we need this Tab press if we're filling with locators? To trigger the calculations?
tpaksu
approved these changes
Jan 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9963
Changes proposed in this Pull Request
Testing instructions
npm run test:e2e-pw merchant-orders-partial-refundnpm run changelogto add a changelog file, choosepatchto leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.Post merge