-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert Shopper Multi Currency Widget spec to Playwright #10204
Open
ismaeldcom
wants to merge
12
commits into
develop
Choose a base branch
from
dev/10067-convert-shopper-multi-currency-widget-spec
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Convert Shopper Multi Currency Widget spec to Playwright #10204
ismaeldcom
wants to merge
12
commits into
develop
from
dev/10067-convert-shopper-multi-currency-widget-spec
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This reverts commit 917bb01.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10067
Changes proposed in this Pull Request
addMulticurrencyWidget
, theisWidgetAdded
check is looking for a heading that is inside an iframe, we need to first wait until every sidebar loads and then look for the widget iframe.createOrder
method, to get a pay order link without using the UI, which is faster and less dependent on WC changes. I think there is room for more API utils, and a refactor to use a singleton, but let's leave that for future optimizations.I've explored the option of using the REST API for adding the widget, to avoid "testing" something outside of WooPayments, but it requires three different calls, making it even slower. Anyway, we could consider doing this differently later, like adding the widget using the CLI in the setup script.
Testing instructions
dev/10067-convert-shopper-multi-currency-widget-spec
npm run test:e2e-pw shopper-multi-currency-widget
npm run changelog
to add a changelog file, choosepatch
to leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.Post merge