Transactions Download functionality Improvements #10211
Open
+282
−100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test the buildOption 1. Jetpack Beta
Option 2. Jurassic Ninja - available for logged-in A12s🚀 Launch a JN site with this branch 🚀 ℹ️ Install this Tampermonkey script to get more options. Build info:
Note: the build is updated when a new commit is pushed to this PR. |
|
Size Change: +495 B (0%) Total Size: 1.36 MB
ℹ️ View Unchanged
|
Jinksi
reviewed
Jan 22, 2025
client/transactions/list/index.tsx
Outdated
| ) | ||
| ); | ||
| if ( response.export_id ) { | ||
| setTimeout( async () => { |
There was a problem hiding this comment.
We could use an interval to continue to poll the endpoint to see if the file is ready, e.g. check every 1s to a maximum of 5s.
There was a problem hiding this comment.
Confused about how much wait time is ideal.
There was a problem hiding this comment.
Me too. I'm thinking we check every ~1s, and set a max retries param.
I've explored this in #10212
Jinksi
reviewed
Jan 22, 2025
6 tasks
jessy-p
changed the title
jessy-p
changed the title
jessy-p
commented
Jan 22, 2025
- The response is changed to an array - If the file times out, don't show an error. The file may be emailed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9969
Changes proposed in this Pull Request
@woocommerce/csv-exportbased JS export on the Transactions pagetransactions/downloadendpoint for all downloads instead.export_idtransactions/download/<export_id>endpoint to get the download URL.By removing the browser export and using only server based export, the functionality is simplified and made consistent. We also preserve the functionality for the merchant by making the file available immediately in the browser whenever possible.
Testing instructions
To be tested with server PR https://github.com/Automattic/transact-platform-server/pull/7154
npm run changelogto add a changelog file, choosepatchto leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.Post merge