feat: query host to check if dhcp rehydration feature is enabled before issuing dhcp request #3318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ending workaround dhcp request if so
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Change:
There is a temporary workaround in swiftv2 linux which requires the cni to send a dhcp request when adding secondary nics. A more permanent fix is available, but once that is merged in, cni will still attempt to send the dhcp request and will fail perpetually. This PR adds a check to see if the dhcp rehydration feature (the more permanent fix) is enabled on the host before sending the dhcp request.
Issue Fixed:
See above
Requirements:
Notes:
Only affects swiftv2 linux setups with delegated nics