Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor workflows and helm chart #70

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

bonddim
Copy link

@bonddim bonddim commented Jun 28, 2024

Changes

Helm chart

  • Updated chart with helm best practices.
  • Added more configuration options.
  • Generated chart Readme with helm-doc

Note

Deployment resource should be deleted before upgrade - immutable matchLabels was changed.

Workflows

  • Updated all actions to latest version and added dependabot config
  • Moved image build/publish into publish.yaml workflow
  • Rewrite gh-pages update job
  • Publish helm chart to ghcr.io oci registry also
  • Added chart-testing job to pr.yaml workflow
  • publish.yaml workflow is triggered from pr.yaml also, but without publishing any artifacts to registries
  • Removed unused cd.yaml and utils scripts

Note

Updated release process (to avoid released image and chart overrides):

  • release artifacts are builded/published on tag push events and pre-release on push to main
  • pre-release version is incremented automatically
  • Image with latest tag is published on main builds as previously

PS:
code-quality_checks job was renamed into code-quality

Copy link
Collaborator

@eedorenko eedorenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Thanks for the contribution!

@bonddim
Copy link
Author

bonddim commented Sep 16, 2024

@eedorenko will you merge this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants