Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update basin3d version to fix EPA bug #57

Merged
merged 1 commit into from
Jan 10, 2024
Merged

Update basin3d version to fix EPA bug #57

merged 1 commit into from
Jan 10, 2024

Conversation

dschristianson
Copy link
Contributor

@dschristianson dschristianson commented Jan 9, 2024

Update basin3d version 1.0.2 to fix EPA bug

Closes #56

Note: update to test_catalog will need to be revised once additional units issues are corrected in basin3d. The units issues do not affect the current plugins since the datasource unit is reported in the measurement TVP time series observation objects.

Self review:

  • unit tests, mypy, flake8 all pass
  • manually tested

Copy link
Contributor

@vchendrix vchendrix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@vchendrix vchendrix merged commit ff5d282 into main Jan 10, 2024
3 checks passed
@vchendrix vchendrix deleted the update-basin3d branch January 10, 2024 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

EPA plugin returns incorrect time series
2 participants