Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
llddang
requested review from
jasper200207,
pipisebastian,
mun-kyeong and
yeonddori
jasper200207
approved these changes
Jun 29, 2024
| } else { | ||
| swiper?.slideTo(idx); | ||
| } | ||
| }; | ||
|
|
||
| useEffect(() => { | ||
| getTeams().then((res) => { | ||
| const teams = res.body.slice(0, 10).map((team: TeamRank, _: number) => { |
There was a problem hiding this comment.
큰 의미는 없을 듯 하지만 사용하는 변수라면 _ 대신 변수명으로 쓰면 좋을 듯 합니다
src/components/Garden3D/index.tsx
Outdated
| {gardenInfos.map((info) => { | ||
| const currX = (info.week - standX) * gap; | ||
| const currZ = (info.date - 3) * gap; | ||
| {gardenInfo.map((info, _) => { |
There was a problem hiding this comment.
그건 gardenInfos의 idx를 나타냅니다!
yeonddori
reviewed
Jun 29, 2024
src/components/Garden3D/index.tsx
Outdated
Comment on lines
35
to
36
| garden.reduce((prev, value) => { | ||
| return prev.contributeCount >= value.contributeCount ? prev : value; |
There was a problem hiding this comment.
혹시 저만 여기 타입 에러가 발생할까요..?
빈 배열에 대해 초기값이 없는 경우 타입 에러가 발생한다고 뜨는데, 다른 분들은 안뜨시나요?
There was a problem hiding this comment.
혹시 지금도 발생하나요?
저는 에러가 발생하지 않았어요..
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
관련 이슈
작업 요약
리뷰 요구 사항
15분