Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update sarek version in exomeeb #341

Merged
merged 3 commits into from
Sep 19, 2024
Merged

update sarek version in exomeeb #341

merged 3 commits into from
Sep 19, 2024

Conversation

OPSergio
Copy link
Contributor

@OPSergio OPSergio commented Sep 12, 2024 •
edited by victor5lm
Loading

PR checklist

  • This comment contains a description of changes (with reason).
  • Make sure your code lints (black and flake8).
  • If a new tamplate was added make sure:
    • Template's schema is added in templates/services.json.
    • Template's pipeline's documentation in assets/reports/md/template.md is added.
    • Results Documentation in assets/reports/results/template.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).
  • If you know a new user was added to the SFTP, make sure you added it to templates/sftp_user.json

PR checklist

This PR addresses #340.

@OPSergio OPSergio marked this pull request as draft September 12, 2024 14:52
@OPSergio
Copy link
Contributor Author

Updated sarek version (v3.4.4) in ExomeEB-ExomeTrio-WGSTrio templates

@OPSergio OPSergio marked this pull request as ready for review September 12, 2024 15:27
Shettland
Shettland approved these changes Sep 13, 2024
View reviewed changes
Copy link
Member

@Shettland Shettland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@OPSergio OPSergio merged commit 3a5b571 into BU-ISCIII:develop Sep 19, 2024
2 checks passed
juanledesma78 pushed a commit to juanledesma78/buisciii-tools that referenced this pull request Dec 27, 2024
@OPSergio
update sarek version in exomeeb (BU-ISCIII#341)
e8de247 
* update sarek version in exomeeb

* Updated sarek version (v3.4.4) in ExomeEB-ExomeTrio-WGSTrio templates

* Current version Nextflow
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Shettland Shettland Shettland approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@OPSergio @Shettland