Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reducing time spent opening/reading files when doing /replay list ... commands #293

Closed
wants to merge 2 commits into from
Closed

Reducing time spent opening/reading files when doing /replay list ... commands #293

wants to merge 2 commits into from

Conversation

red15
Copy link

@red15 red15 commented Nov 28, 2021

Implemented:

  • only read/open files that match the search query

Todo:

  • limit number of results from getFileList

@red15
Copy link
Author

red15 commented Nov 28, 2021

Linking to #277

@red15 red15 marked this pull request as ready for review February 10, 2022 11:10
@blast007 blast007 added this to the 2.4.24 milestone Feb 10, 2022
@blast007 blast007 linked an issue Feb 10, 2022 that may be closed by this pull request
Extreme slowness with /replay list with 13,000 replays #277
Open
@blast007 blast007 modified the milestones: 2.4.24, 2.4.26 Mar 11, 2022
red15 added 2 commits January 4, 2023 09:27
@red15
Moved the glob_match call within getFileList
9db6da3 
This reduces the number of files being read/opened when doing a search.
@red15
Add limit to listing files, MaxListOutput (=100)
fed0d59
@red15 red15 closed this Mar 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.4.26
Development

Successfully merging this pull request may close these issues.

Extreme slowness with /replay list with 13,000 replays
2 participants
@red15 @blast007