Merge pull request #5 from BaizeAI/dev/fix-timestamp-issue

fix: lastTimestamp may be null (zero) which could cause events never being processed

README.md

@@ -29,6 +29,7 @@ Configure `kcover` to monitor specific Kubernetes resources by labeling them:
 
 ```shell
 kubectl label pytorchjobs <job-name> kcover.io/cascading-recovery=true
+kubectl label pytorchjobs <job-name> kcover.io/need-recovery=true
 ```
 
 ## Usage

pkg/events/kubeevents.go

@@ -56,8 +56,12 @@ func (a *kubeEventsRecorder) Start() error {
 	_, err := informer.AddEventHandler(cache.ResourceEventHandlerFuncs{
 		AddFunc: func(obj interface{}) {
 			event := obj.(*corev1.Event)
-			if event.LastTimestamp.Add(3 * time.Minute).Before(time.Now()) {
-				klog.Infof("event %s is too old, ignore it", event.Name)
+			eventTimestamp := event.LastTimestamp
+			if eventTimestamp.IsZero() {
+				eventTimestamp = event.CreationTimestamp
+			}
+			if eventTimestamp.Add(3 * time.Minute).Before(time.Now()) {
+				klog.Infof("event %s is too old %s against %s, ignore it", event.Name, eventTimestamp.String(), time.Now().String())
 				return
 			}
 			if event.Annotations[constants.NeedRecoveryAnnotation] == "true" {