Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(golang): improve engine following rules #1383

Merged
merged 1 commit into from
Nov 9, 2023
Merged

fix(golang): improve engine following rules #1383

merged 1 commit into from
Nov 9, 2023

Conversation

cfabianski
Copy link
Collaborator

@cfabianski cfabianski commented Nov 9, 2023 •
edited
Loading

Description

Handle literal_element and literal_value.

Worth noting that the tree-sitter playground for go is using the updated version but our version of tree-sitter-go is still a bit behind.

image

64457ea6b73ef5422ed1687178d4545c3e91334a
image

Checklist

  • I've added test coverage that shows my fix or feature works as expected.
  • I've updated or added documentation if required.
  • I've included usage information in the description if CLI behavior was updated or added.
  • PR title follows Conventional Commits format

@cfabianski cfabianski marked this pull request as ready for review November 9, 2023 10:13
@cfabianski cfabianski merged commit 87eb1ac into main Nov 9, 2023
10 checks passed
@cfabianski cfabianski deleted the fix/improve-golang-engine branch November 9, 2023 10:26
@cfabianski cfabianski requested a review from didroe November 9, 2023 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@didroe didroe Awaiting requested review from didroe

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@cfabianski