Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update rules count #1399

Merged
merged 2 commits into from
Nov 15, 2023
Merged

Conversation

cfabianski
Copy link
Collaborator

Description

image image

Checklist

  • I've added test coverage that shows my fix or feature works as expected.
  • I've updated or added documentation if required.
  • I've included usage information in the description if CLI behavior was updated or added.
  • PR title follows Conventional Commits format

} else if (isDirectory(subDirPath) && subDir === "gosec") {
const groupDirs = await readdir(subDirPath)

console.log("groupDirs ", groupDirs)
Copy link
Contributor

@gotbadger gotbadger Nov 15, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove cosnole log?

if (cweList[i] && cweList[i].owasp) {
owasps.add(cweList[i].owasp.id)
} else {
console.log(`cweList[i] ${JSON.stringify(cweList[i])}`)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove?


function updateCounts(lang, framework = null, id = null) {
console.log(`Lang ${lang} Framework ${framework}`)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
console.log(`Lang ${lang} Framework ${framework}`)

Copy link
Contributor

@gotbadger gotbadger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just remove the debugging and should be good

@cfabianski cfabianski force-pushed the docs/improve-doc-count-following-gosec branch from b5b4ac6 to e52d34f Compare November 15, 2023 10:07
@cfabianski cfabianski merged commit ddbac64 into main Nov 15, 2023
7 checks passed
@cfabianski cfabianski deleted the docs/improve-doc-count-following-gosec branch November 15, 2023 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants