Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added "harmony-lemma-formalization" as a new case study #273

Merged
merged 2 commits into from
Jul 29, 2024
Merged

Added "harmony-lemma-formalization" as a new case study #273

merged 2 commits into from
Jul 29, 2024

Conversation

GabrieleCecilia
Copy link
Contributor

I am providing the Beluga code for the paper "A Beluga Formalization of the Harmony Lemma in the π-Calculus" by Gabriele Cecilia and Alberto Momigliano, so that it can be revised, stored as a case study and eventually updated.

Copy link
Member

@MartyO256 MartyO256 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Type-checking of the file 5_theorem1.bel failed during continuous integration. This is due to an extra argument [g ⊢ _] given to the functions fs_out_rew, bs_in_rew and bs_out_rew in fstep_impl_red.

case-studies/harmony-lemma-formalization/5_theorem1.bel Outdated Show resolved Hide resolved
case-studies/harmony-lemma-formalization/5_theorem1.bel Outdated Show resolved Hide resolved
case-studies/harmony-lemma-formalization/5_theorem1.bel Outdated Show resolved Hide resolved
case-studies/harmony-lemma-formalization/5_theorem1.bel Outdated Show resolved Hide resolved
case-studies/harmony-lemma-formalization/5_theorem1.bel Outdated Show resolved Hide resolved
case-studies/harmony-lemma-formalization/5_theorem1.bel Outdated Show resolved Hide resolved
case-studies/harmony-lemma-formalization/5_theorem1.bel Outdated Show resolved Hide resolved
case-studies/harmony-lemma-formalization/5_theorem1.bel Outdated Show resolved Hide resolved
@MartyO256
Copy link
Member

Thank you for your contribution! Incorporating your case study will help us improve the implementation of Beluga.

Please let me know if the changes I requested above are acceptable.

@GabrieleCecilia
Copy link
Contributor Author

Thank you for your work: you are right about the mistakes. This is because I actually uploaded an update of the functions bs_in_rew, fs_out_rew and bs_out_rew (in which I removed an unnecessary explicit argument and performed a more efficient induction) without remembering to update the function fstep_impl_red as well. Correctness of my code is something I should have checked beforehand: I apologize for being superficial.

In conclusion: you can apply the changes you suggested. After applying them, the code is correct.

Remove extra `[g ⊢ _]` arguments in `fstep_impl_red`
@MartyO256 MartyO256 merged commit 5efb5c7 into Beluga-lang:master Jul 29, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants