Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect type hints for poppler_path arguments #294

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

bartfeenstra
Copy link

Mypy complained that I wanted to pass on None to convert_from_path()'s poppler_path argument. I found that these arguments were not properly typed in a number of places, so I corrected them.

Note: the same problem of arguments allowing None but not being typed as such is present across the codebase, but I figured let's start small.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant