Move MemoryOperatorError enum values out of global scope #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
oh wtf why are old commits there |
|
You didn't pull from upstream after a merge I guess. |
|
i could've sworn i did, anyway |
|
Want to fix it or nah? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MillzyDev@0bf954e - Moved EarlyGlobals.cmake include to after CMAKE project declaration. The default value for
CMAKE_SYSTEM_PROCESSORis not assigned until after the project is declared. This resulted in a fatal error case, as CMAKE_SYSTEM_PROCESSOR had no value.MillzyDev@ae7c1a4 - Added a non-typedef name to the
MemoryOperationErrorenum. Identifiers such askNoneare common and presents naming conflicts with local-scoped constexpr values and other enums (see image). As far as I could find, this change did not result in any compilation errors afterwards.