Revert "feat: wonder model" #2396
Conversation
This reverts commit ae73dfd.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
WalkthroughThe changes in this pull request primarily involve the removal of the Changes
Possibly related PRs
Suggested reviewers
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
|
You are out of MentatBot reviews. Your usage will refresh December 16 at 08:00 AM. |
|
Failed to generate code suggestions for PR |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (4)
client/src/dojo/modelManager/TileManager.ts(0 hunks)client/src/three/components/StructureManager.ts(1 hunks)client/src/three/scenes/Hexception.tsx(1 hunks)client/src/three/scenes/constants.ts(1 hunks)
💤 Files with no reviewable changes (1)
- client/src/dojo/modelManager/TileManager.ts
🔇 Additional comments (1)
client/src/three/components/StructureManager.ts (1)
17-17: Verify wonder model handling is completely removed.
The WONDER_MODEL_INDEX constant has been removed. This change appears to be part of the wonder feature revert.
Let's verify all wonder-related model handling is removed:
| export const buildingModelPaths: Record< | ||
| BuildingType | ResourceMiningTypes | RealmLevelNames | HyperstructureTypesNames | typeof WONDER_REALM, | ||
| BuildingType | ResourceMiningTypes | RealmLevelNames | HyperstructureTypesNames, |
There was a problem hiding this comment.
💡 Codebase verification
Wonder-related code still present in multiple locations
Several wonder-related code references still exist across the codebase that may need attention:
client/src/three/components/Minimap.ts: Contains wonder-related texture paths and logicclient/src/ui/utils/utils.tsx: HasadjustWonderLordsCostfunctionclient/src/ui/utils/realms.tsx: Contains wonder-related logic and namingclient/src/dojo/modelManager/ResourceManager.ts: Contains wonder-specific resource production logicclient/src/three/components/StructureManager.ts: Has wonder-related parameters and logic
🔗 Analysis chain
LGTM: Wonder type successfully removed from buildingModelPaths.
The type definition has been correctly updated to remove the wonder-related type.
Let's verify no other wonder-related constants remain in the codebase:
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Search for any remaining wonder-related constants
rg -i 'wonder' --type ts
Length of output: 6653
| @@ -98,7 +97,7 @@ interface Building { | |||
| export default class HexceptionScene extends HexagonScene { | |||
| private hexceptionRadius = 4; | |||
| private buildingModels: Map< | |||
| BuildingType | ResourceMiningTypes | typeof WONDER_REALM, | |||
| BuildingType | ResourceMiningTypes, | |||
There was a problem hiding this comment.
💡 Codebase verification
Found remaining wonder-related code that needs attention
The search revealed several remaining wonder-related implementations that should be reviewed:
- Wonder-related scene handling in label management (MY_REALM_WONDER, REALM_WONDER labels and their loading)
- Wonder-specific logic for resource costs (adjustWonderLordsCost function)
- Wonder-related structure properties and handling (hasWonder flag in structures)
- Wonder-specific resource production rate adjustments
These findings suggest the wonder feature removal is incomplete. The changes should be consistent across the entire codebase.
🔗 Analysis chain
LGTM: Wonder type successfully removed from buildingModels Map.
The type definition has been correctly updated to remove the wonder-related type, consistent with changes in constants.ts.
Let's verify no wonder-related scene handling remains:
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Search for any remaining wonder-related scene handling
ast-grep --pattern 'if ($this.tileManager.getWonder()) {
$$$
}'
# Search for any remaining wonder-related imports or type usage
rg -i 'wonder.*realm|realm.*wonder' --type tsx
Length of output: 144
Script:
#!/bin/bash
# Search for any remaining wonder-related scene handling with ripgrep
rg -i "wonder" --type ts --type tsx -A 3
# Search for any remaining wonder-related imports or type usage
rg -i "wonderrealm|realm.*wonder" --type ts --type tsx
# Search for getWonder method usage
rg -i "getWonder\(" --type ts --type tsx
Length of output: 224
Script:
#!/bin/bash
# Search for any remaining wonder-related scene handling with ripgrep
# Note: Using just typescript extension since tsx isn't recognized
rg -i "wonder" "*.ts"
# Search for getWonder method usage
rg -i "getWonder\(" "*.ts"
# Find all TypeScript files that might contain wonder-related code
fd -e ts -e tsx -x cat {} | rg -i "wonder"
Length of output: 3993
This reverts commit ae73dfd.
Summary by CodeRabbit
New Features
Bug Fixes
WONDER_REALM, streamlining the handling of building models.Documentation