Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Maintenance) Partial API updates for db failure #1317

Merged
merged 1 commit into from
Mar 29, 2024

Conversation

nick-bisonai
Copy link
Collaborator

Description

AS IS

API

2024/03/29 17:48:28 | (chain/controller.go:33) panic: ERROR: duplicate key value violates unique constraint "chains_name_key" (SQLSTATE 23505)
goroutine 22 [running]:
runtime/debug.Stack()
        /opt/homebrew/Cellar/go/1.21.5/libexec/src/runtime/debug/stack.go:24 +0x64
bisonai.com/orakl/api/utils.CustomStackTraceHandler(0x14000001c20?, {0x100f30e60?, 0x140001740f0})
        /Users/nick/development/orakl/api/utils/utils.go:333 +0x1d8
bisonai.com/orakl/api/utils.Setup.New.func2.1()
        /Users/nick/.go/pkg/mod/github.com/gofiber/fiber/[email protected]/middleware/recover/recover.go:31 +0x70
panic({0x100f30e60?, 0x140001740f0?})
        /opt/homebrew/Cellar/go/1.21.5/libexec/src/runtime/panic.go:914 +0x218
bisonai.com/orakl/api/chain.insert(0x100f20820?)
        /Users/nick/development/orakl/api/chain/controller.go:33 +0x17c
github.com/gofiber/fiber/v2.(*App).next(0x14000134000, 0x140001e4300)
        /Users/nick/.go/pkg/mod/github.com/gofiber/fiber/[email protected]/router.go:145 +0x188
github.com/gofiber/fiber/v2.(*Ctx).Next(0x100fdfb00?)
        /Users/nick/.go/pkg/mod/github.com/gofiber/fiber/[email protected]/ctx.go:1030 +0x5c
bisonai.com/orakl/api/utils.Setup.func1(0x100?)
        /Users/nick/development/orakl/api/utils/utils.go:183 +0x104
github.com/gofiber/fiber/v2.(*Ctx).Next(0x14000140330?)
        /Users/nick/.go/pkg/mod/github.com/gofiber/fiber/[email protected]/ctx.go:1027 +0x48
github.com/gofiber/fiber/v2/middleware/cors.New.func1(0x140001e4300)
        /Users/nick/.go/pkg/mod/github.com/gofiber/fiber/[email protected]/middleware/cors/cors.go:166 +0x318
github.com/gofiber/fiber/v2.(*Ctx).Next(0x1400014daf8?)
        /Users/nick/.go/pkg/mod/github.com/gofiber/fiber/[email protected]/ctx.go:1027 +0x48
bisonai.com/orakl/api/utils.Setup.New.func2(0x100f20820?)
        /Users/nick/.go/pkg/mod/github.com/gofiber/fiber/[email protected]/middleware/recover/recover.go:43 +0xa4
github.com/gofiber/fiber/v2.(*App).next(0x14000134000, 0x140001e4300)
        /Users/nick/.go/pkg/mod/github.com/gofiber/fiber/[email protected]/router.go:145 +0x188
github.com/gofiber/fiber/v2.(*App).handler(0x14000134000, 0x100b7a4e8?)
        /Users/nick/.go/pkg/mod/github.com/gofiber/fiber/[email protected]/router.go:172 +0x74
github.com/valyala/fasthttp.(*Server).serveConn(0x1400051c000, {0x100ff7b28?, 0x14000522200})
        /Users/nick/.go/pkg/mod/github.com/valyala/[email protected]/server.go:2374 +0xdd0
github.com/valyala/fasthttp.(*workerPool).workerFunc(0x14000480000, 0x14000520280)
        /Users/nick/.go/pkg/mod/github.com/valyala/[email protected]/workerpool.go:224 +0x70
github.com/valyala/fasthttp.(*workerPool).getCh.func1()
        /Users/nick/.go/pkg/mod/github.com/valyala/[email protected]/workerpool.go:196 +0x38
created by github.com/valyala/fasthttp.(*workerPool).getCh in goroutine 1
        /Users/nick/.go/pkg/mod/github.com/valyala/[email protected]/workerpool.go:195 +0x208

2024/03/29 17:48:28 | 500 | 127.0.0.1 | POST | /api/v1/chain | ERROR: duplicate key value violates unique constraint "chains_name_key" (SQLSTATE 23505)

CLI

❯❯❯ yarn cli chain insert --name test
yarn run v1.22.21
$ node --no-warnings --import=specifier-resolution-node/register --experimental-json-modules dist/index.js chain insert --name test
Chain was not inserted. Reason:
ERROR: duplicate key value violates unique constraint "chains_name_key" (SQLSTATE 23505)

TO BE

API

// no error message occurs from api 

CLI

❯❯❯ yarn cli chain insert --name test
yarn run v1.22.21
$ node --no-warnings --import=specifier-resolution-node/register --experimental-json-modules dist/index.js chain insert --name test
Chain was not inserted. Reason:
failed to insert chain: ERROR: duplicate key value violates unique constraint "chains_name_key" (SQLSTATE 23505)
✨  Done in 0.37s.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist before requesting a review

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.

Deployment

  • Should publish npm package
  • Should publish Docker image

@nick-bisonai nick-bisonai self-assigned this Mar 29, 2024
@nick-bisonai nick-bisonai requested a review from a team as a code owner March 29, 2024 08:52
Copy link
Contributor

coderabbitai bot commented Mar 29, 2024

Warning

Rate Limit Exceeded

@nick-bisonai has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 17 minutes and 36 seconds before requesting another review.

How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.
Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.
Please see our FAQ for further information.

Commits Files that changed from the base of the PR and between af69ed7 and eadac17.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit-tests for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit tests for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit tests.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

@nick-bisonai nick-bisonai changed the title (Maintenance) Partial updates for db failure (Maintenance) Partial API updates for db failure Mar 29, 2024
@nick-bisonai nick-bisonai linked an issue Mar 29, 2024 that may be closed by this pull request
Copy link
Member

@martinkersner martinkersner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@nick-bisonai
Copy link
Collaborator Author

@coderabbitai review

@nick-bisonai nick-bisonai merged commit d8ef9ab into master Mar 29, 2024
1 check passed
@nick-bisonai nick-bisonai deleted the fix/api-error-handling branch March 29, 2024 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cli returning vague error message
2 participants