-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(API) Remove unused redis reference #1834
Conversation
Caution Review failedThe pull request is closed. WalkthroughWalkthroughThe recent changes involve removing Redis-related code from the project. This includes eliminating Redis connections, setup, and operations throughout various test files and the main application setup. Additionally, import statements are reorganized, some unused imports are removed, and Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (8)
- api/tests/apierr_test.go (2 hunks)
- api/tests/chain_test.go (2 hunks)
- api/tests/listener_test.go (2 hunks)
- api/tests/proxy_test.go (2 hunks)
- api/tests/reporter_test.go (2 hunks)
- api/tests/service_test.go (2 hunks)
- api/tests/vrf_test.go (2 hunks)
- api/utils/utils.go (4 hunks)
Additional comments not posted (11)
api/tests/chain_test.go (1)
7-8
: Approved import additions.The added imports for
chain
andutils
are correctly placed and used within theTestChain
function for various operations like setup and API requests.api/tests/service_test.go (1)
7-8
: Approved import additions.The added imports for
service
andutils
are correctly placed and used within theTestService
function for various operations like setup and API requests.api/tests/proxy_test.go (1)
7-8
: Approved import additions.The added imports for
proxy
andutils
are correctly placed and used within theTestProxy
function for various operations like setup and API requests.api/tests/apierr_test.go (1)
9-10
: Approved import additions.The added imports for
apierr
andutils
are correctly placed and used within theTestApiErr
function for various operations like setup and API requests.api/tests/listener_test.go (2)
4-6
: Approved: Import reorganization.The reordering of imports (
fmt
andtesting
moved to the top) follows Go's convention of grouping standard library imports together, separated from third-party imports. This improves readability and organization.
Line range hint
14-19
: Approved: Removal of unused Redis references.The removal of
redisClient
and its associateddefer
statement is consistent with the PR's objective to eliminate unused Redis references. This should streamline the test setup without affecting functionality.api/tests/reporter_test.go (2)
4-6
: Approved: Import reorganization.The reordering of imports (
fmt
andtesting
moved to the top) is a good practice in Go, enhancing clarity and maintainability.
Line range hint
14-19
: Approved: Removal of unused Redis references.The removal of Redis setup and defer statements in the
TestReporter
function aligns with the PR's objective and should not affect test outcomes if the Redis dependency was indeed unused.api/tests/vrf_test.go (2)
4-6
: Approved: Import reorganization.The reordering of imports (
fmt
andtesting
moved to the top) is a good practice in Go, enhancing clarity and maintainability.
Line range hint
14-19
: Approved: Removal of unused Redis references.The removal of Redis setup and defer statements in the
TestVrf
function aligns with the PR's objective and should not affect test outcomes if the Redis dependency was indeed unused.api/utils/utils.go (1)
Line range hint
4-6
: Approved: Significant cleanup in AppConfig and related functions.The removal of the
Redis
field fromAppConfig
and the associated Redis functions (GetRdb
,SetRedis
,GetRedis
) simplifies the application configuration. This aligns with the PR's objective to remove unused Redis references and should not introduce issues if Redis was indeed unused.
Description
Remove redis reference which were looking at
data-feed
redisType of change
Please delete options that are not relevant.
Checklist before requesting a review
Deployment