Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(API) Remove unused redis reference #1834

Merged
merged 3 commits into from
Jul 17, 2024
Merged

(API) Remove unused redis reference #1834

merged 3 commits into from
Jul 17, 2024

Conversation

nick-bisonai
Copy link
Collaborator

Description

Remove redis reference which were looking at data-feed redis

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist before requesting a review

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.

Deployment

  • Should publish npm package
  • Should publish Docker image

@nick-bisonai nick-bisonai self-assigned this Jul 17, 2024
@nick-bisonai nick-bisonai requested a review from a team as a code owner July 17, 2024 08:42
Copy link
Contributor

coderabbitai bot commented Jul 17, 2024

Caution

Review failed

The pull request is closed.

Walkthrough

Walkthrough

The recent changes involve removing Redis-related code from the project. This includes eliminating Redis connections, setup, and operations throughout various test files and the main application setup. Additionally, import statements are reorganized, some unused imports are removed, and golang-migrate installation is added in the GitHub workflow.

Changes

Files Change Summary
api/tests/apierr_test.go Reordered imports, removed Redis client setup and closing.
api/tests/chain_test.go Reordered imports, removed Redis client setup and closing.
api/tests/listener_test.go Reordered imports, removed Redis client setup and closing.
api/tests/proxy_test.go Reordered imports, removed Redis client setup and closing.
api/tests/reporter_test.go Reordered imports, removed Redis client setup and closing.
api/tests/service_test.go Reordered imports, removed Redis client setup and closing.
api/tests/vrf_test.go Reordered imports, removed Redis client setup and closing.
api/utils/utils.go Removed Redis field from AppConfig, related functions, and setup logic.
.github/workflows/api.test.yaml Removed linting and vetting steps for the Go code, added installation of golang-migrate.
api/main.go Removed Redis initialization and deferred closing.

Poem

In code, a change has come to light,
With Redis gone, the tests are bright.
Imports shuffled, cleanup clear,
The app now runs without a fear.
Golang-migrate steps in stride,
A new dawn for our project's pride.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 7c75f7d and 661c9bb.

Files selected for processing (8)
  • api/tests/apierr_test.go (2 hunks)
  • api/tests/chain_test.go (2 hunks)
  • api/tests/listener_test.go (2 hunks)
  • api/tests/proxy_test.go (2 hunks)
  • api/tests/reporter_test.go (2 hunks)
  • api/tests/service_test.go (2 hunks)
  • api/tests/vrf_test.go (2 hunks)
  • api/utils/utils.go (4 hunks)
Additional comments not posted (11)
api/tests/chain_test.go (1)

7-8: Approved import additions.

The added imports for chain and utils are correctly placed and used within the TestChain function for various operations like setup and API requests.

api/tests/service_test.go (1)

7-8: Approved import additions.

The added imports for service and utils are correctly placed and used within the TestService function for various operations like setup and API requests.

api/tests/proxy_test.go (1)

7-8: Approved import additions.

The added imports for proxy and utils are correctly placed and used within the TestProxy function for various operations like setup and API requests.

api/tests/apierr_test.go (1)

9-10: Approved import additions.

The added imports for apierr and utils are correctly placed and used within the TestApiErr function for various operations like setup and API requests.

api/tests/listener_test.go (2)

4-6: Approved: Import reorganization.

The reordering of imports (fmt and testing moved to the top) follows Go's convention of grouping standard library imports together, separated from third-party imports. This improves readability and organization.


Line range hint 14-19: Approved: Removal of unused Redis references.

The removal of redisClient and its associated defer statement is consistent with the PR's objective to eliminate unused Redis references. This should streamline the test setup without affecting functionality.

api/tests/reporter_test.go (2)

4-6: Approved: Import reorganization.

The reordering of imports (fmt and testing moved to the top) is a good practice in Go, enhancing clarity and maintainability.


Line range hint 14-19: Approved: Removal of unused Redis references.

The removal of Redis setup and defer statements in the TestReporter function aligns with the PR's objective and should not affect test outcomes if the Redis dependency was indeed unused.

api/tests/vrf_test.go (2)

4-6: Approved: Import reorganization.

The reordering of imports (fmt and testing moved to the top) is a good practice in Go, enhancing clarity and maintainability.


Line range hint 14-19: Approved: Removal of unused Redis references.

The removal of Redis setup and defer statements in the TestVrf function aligns with the PR's objective and should not affect test outcomes if the Redis dependency was indeed unused.

api/utils/utils.go (1)

Line range hint 4-6: Approved: Significant cleanup in AppConfig and related functions.

The removal of the Redis field from AppConfig and the associated Redis functions (GetRdb, SetRedis, GetRedis) simplifies the application configuration. This aligns with the PR's objective to remove unused Redis references and should not introduce issues if Redis was indeed unused.

@nick-bisonai nick-bisonai merged commit f15e4a1 into master Jul 17, 2024
1 check passed
@nick-bisonai nick-bisonai deleted the feat/hotfix-api branch July 17, 2024 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant