Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cli adapter hash error msg #898

Merged
merged 2 commits into from
Nov 8, 2023
Merged

Conversation

nick-bisonai
Copy link
Collaborator

Description

fixed error message to see detailed reason

// before
yarn cli adapter hash --verify --source '/Users/nick/development/orakl-config/adapter/wemix-usdt.adapter.json'
yarn run v1.22.19
$ node --no-warnings --experimental-specifier-resolution=node --experimental-json-modules dist/index.js adapter hash --verify --source /Users/nick/development/orakl-config/adapter/wemix-usdt.adapter.json
Adapter hash could not be computed. Reason:
Request failed with status code 400

// after
❯❯❯ yarn cli adapter hash --verify --source '/Users/nick/development/orakl-config/adapter/wemix-usdt.adapter.json'
yarn run v1.22.19
$ node --no-warnings --experimental-specifier-resolution=node --experimental-json-modules dist/index.js adapter hash --verify --source /Users/nick/development/orakl-config/adapter/wemix-usdt.adapter.json
Adapter hash could not be computed. Reason:
Hashes do not match!
Expected 0x64fa89f33bdaa0a908aad6218e7eeff04b9229533c176e8e9cf68eeae0ff2869, received 0x64fa89f33bdddaa0a908aad6218e7eeff04b9229533c176e8e9cf68eeae0ff2869.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist before requesting a review

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.

Deployment

  • Should publish npm package
  • Should publish Docker image

@nick-bisonai nick-bisonai self-assigned this Nov 8, 2023
@nick-bisonai nick-bisonai requested a review from a team as a code owner November 8, 2023 04:50
@nick-bisonai nick-bisonai linked an issue Nov 8, 2023 that may be closed by this pull request
Copy link
Member

@martinkersner martinkersner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@nick-bisonai nick-bisonai merged commit b9ff704 into master Nov 8, 2023
1 check passed
@nick-bisonai nick-bisonai deleted the i-878/fix/adapter-hash-fix branch November 8, 2023 04:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

orakl cli adapter hash returns code 400 when hashes do not match
2 participants