Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Specify node version for @bisonai/orakl-cli package #980

Merged
merged 1 commit into from
Nov 27, 2023
Merged

Specify node version for @bisonai/orakl-cli package #980

merged 1 commit into from
Nov 27, 2023

Conversation

martinkersner
Copy link
Member

Description

Specify node version for @bisonai/orakl-cli using .nvmrc.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist before requesting a review

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.

@martinkersner martinkersner self-assigned this Nov 27, 2023
@martinkersner martinkersner requested a review from a team as a code owner November 27, 2023 10:39
@martinkersner martinkersner linked an issue Nov 27, 2023 that may be closed by this pull request
cli not working in recent node version (v21) #896
Closed
bayram98
bayram98 approved these changes Nov 27, 2023
View reviewed changes
Copy link
Contributor

@bayram98 bayram98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

nick-bisonai
nick-bisonai approved these changes Nov 27, 2023
View reviewed changes
Copy link
Collaborator

@nick-bisonai nick-bisonai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@martinkersner martinkersner merged commit 27fd9f3 into master Nov 27, 2023
1 check passed
@martinkersner martinkersner deleted the i-896/feat/specify-node-version-for-cli branch November 27, 2023 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nick-bisonai nick-bisonai nick-bisonai approved these changes

@bayram98 bayram98 bayram98 approved these changes

Assignees

@martinkersner martinkersner

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

cli not working in recent node version (v21)
3 participants
@martinkersner @bayram98 @nick-bisonai