Implemented findings of gabryelreyes

lib/AppSensorFusion/SerialMuxChannels.h

@@ -92,7 +92,7 @@ typedef struct _SensorData
      */
     int16_t magnetometerValueY;
 
-    /** Gyroscope value around z axis as a raw sensor value in digits.
+    /** Gyro value around z axis as a raw sensor value in digits.
      * It can be converted into a physical turn rate in mrad/s via the multiplication
      * with a sensitivity factor in mrad/s/digit.
      */

lib/HALConvoyLeaderSim/Board.h

@@ -215,7 +215,7 @@ class Board : public IBoard
     }
 
     /**
-     * Get IMU (=Inertial Measurement Unit) driver.
+     * Get IMU (Inertial Measurement Unit) driver.
      *
      * @return IMU driver
      */

lib/HALConvoyLeaderTarget/Board.h

@@ -210,7 +210,7 @@ class Board : public IBoard
     }
 
     /**
-     * Get IMU (=Inertial Measurement Unit) driver.
+     * Get IMU (Inertial Measurement Unit) driver.
      *
      * @return IMU driver
      */

lib/HALConvoyLeaderTarget/ConvoyLeaderIMU.h

@@ -44,6 +44,15 @@
  * Includes
  *****************************************************************************/
 #include "IIMU.h"
+
+/******************************************************************************
+ * Macros
+ *****************************************************************************/
+
+/******************************************************************************
+ * Types and Classes
+ *****************************************************************************/
+
 /** The IMU adapter as a dummy driver for the IMU of the Convoy Leader Application.
  * IMU stands for Inertial Measurement Unit.
  */
@@ -142,7 +151,7 @@ class ConvoyLeaderIMU : public IIMU
     }
 
     /**
-     * Get last raw Gyroscope values as an IMUData struct containing values in x, y and z in digits.
+     * Get last raw Gyro values as an IMUData struct containing values in x, y and z in digits.
      *
      * @param[in] turnRates  Pointer to IMUData struct where the raw turn Rates in digits in x, y and z
      * direction will be written into. The values can be converted into physical values in mrad/s via the multiplication

lib/HALInterfaces/IBoard.h

@@ -167,7 +167,7 @@ class IBoard
 
 
     /**
-     * Get IMU (=Inertial Measurement Unit) driver.
+     * Get IMU (Inertial Measurement Unit) driver.
      * 
      * @return IMU driver
      */

lib/HALInterfaces/IIMU.h

@@ -52,7 +52,7 @@
  * Types and Classes
  *****************************************************************************/
 
-/** Struct of the raw and not yet converted IMU Data (=accelerometer, gyro or magnetometer values)
+/** Struct of the raw and not yet converted IMU Data (accelerometer, gyro or magnetometer values)
  * in digits in x, y and z direction. */
 typedef struct _IMUData
 {
@@ -137,7 +137,7 @@ class IIMU
     virtual const void getAccelerationValues(IMUData* accelerationValues) = 0;
 
     /**
-     * Get last raw Gyroscope values as an IMUData struct containing values in x, y and z in digits.
+     * Get last raw Gyro values as an IMUData struct containing values in x, y and z in digits.
      *
      * @param[in] turnRates  Pointer to IMUData struct where the raw turn Rates in digits in x, y and z
      * direction will be written into. The values can be converted into physical values in mrad/s via the multiplication

lib/HALLineFollowerSim/Board.h

@@ -215,7 +215,7 @@ class Board : public IBoard
     }
 
     /**
-     * Get IMU (=Inertial Measurement Unit) driver.
+     * Get IMU (Inertial Measurement Unit) driver.
      *
      * @return IMU driver
      */

lib/HALLineFollowerTarget/Board.h

@@ -210,7 +210,7 @@ class Board : public IBoard
     }
 
     /**
-     * Get IMU (=Inertial Measurement Unit) driver.
+     * Get IMU (Inertial Measurement Unit) driver.
      *
      * @return IMU driver
      */

lib/HALLineFollowerTarget/LineFollowerIMU.h

@@ -44,6 +44,15 @@
  * Includes
  *****************************************************************************/
 #include "IIMU.h"
+
+/******************************************************************************
+ * Macros
+ *****************************************************************************/
+
+/******************************************************************************
+ * Types and Classes
+ *****************************************************************************/
+
 /** The IMU adapter as a dummy driver for the IMU of the LineFollower Application.
  * IMU stands for Inertial Measurement Unit.
  */
@@ -142,7 +151,7 @@ class LineFollowerIMU : public IIMU
     }
 
     /**
-     * Get last raw Gyroscope values as an IMUData struct containing values in x, y and z in digits.
+     * Get last raw Gyro values as an IMUData struct containing values in x, y and z in digits.
      *
      * @param[in] turnRates  Pointer to IMUData struct where the raw turn Rates in digits in x, y and z
      * direction will be written into. The values can be converted into physical values in mrad/s via the multiplication

lib/HALRemoteControlSim/Board.h

@@ -215,7 +215,7 @@ class Board : public IBoard
     }
 
     /**
-     * Get IMU (=Inertial Measurement Unit) driver.
+     * Get IMU (Inertial Measurement Unit) driver.
      *
      * @return IMU driver
      */

lib/HALRemoteControlTarget/Board.h

@@ -210,7 +210,7 @@ class Board : public IBoard
     }
 
     /**
-     * Get IMU (=Inertial Measurement Unit) driver.
+     * Get IMU (Inertial Measurement Unit) driver.
      *
      * @return IMU driver
      */

lib/HALRemoteControlTarget/RemoteControlIMU.h

@@ -44,6 +44,15 @@
  * Includes
  *****************************************************************************/
 #include "IIMU.h"
+
+/******************************************************************************
+ * Macros
+ *****************************************************************************/
+
+/******************************************************************************
+ * Types and Classes
+ *****************************************************************************/
+
 /** The IMU adapter as a dummy driver for the IMU of the RemoteControl Application.
  * IMU stands for Inertial Measurement Unit.
  */
@@ -142,7 +151,7 @@ class RemoteControlIMU : public IIMU
     }
 
     /**
-     * Get last raw Gyroscope values as an IMUData struct containing values in x, y and z in digits.
+     * Get last raw Gyro values as an IMUData struct containing values in x, y and z in digits.
      *
      * @param[in] turnRates  Pointer to IMUData struct where the raw turn Rates in digits in x, y and z
      * direction will be written into. The values can be converted into physical values in mrad/s via the multiplication

lib/HALSensorFusionSim/Board.h

@@ -215,7 +215,7 @@ class Board : public IBoard
     }
 
     /**
-     * Get IMU (=Inertial Measurement Unit) driver.
+     * Get IMU (Inertial Measurement Unit) driver.
      *
      * @return IMU driver
      */

lib/HALSensorFusionTarget/Board.cpp

@@ -76,9 +76,10 @@ void Board::init()
     m_lineSensors.init();
     m_motors.init();
     m_proximitySensors.initFrontSensor();
-    m_imu.init();
+    /*  TODO: TD084	React if IMU initialization fails */
+    (void)m_imu.init();
     m_imu.enableDefault();
-    m_imu.configureForTurnSensing();    
+    m_imu.configureForTurnSensing();
     m_imu.calibrate();
 }
 

lib/HALSensorFusionTarget/Board.h

@@ -209,7 +209,7 @@ class Board : public IBoard
     }
 
     /**
-     * Get IMU (=Inertial Measurement Unit) driver.
+     * Get IMU (Inertial Measurement Unit) driver.
      *
      * @return IMU driver
      */

lib/HALSensorFusionTarget/SensorFusionBuzzer.cpp

@@ -60,14 +60,22 @@
 
 void SensorFusionBuzzer::playFrequency(uint16_t freq, uint16_t duration, uint8_t volume)
 {
+    /* Not implemented*/
+    (void) freq;
+    (void) duration;
+    (void) volume;
 }
 
 void SensorFusionBuzzer::playMelody(const char* sequence)
 {
+    /* Not implemented*/
+    (void) sequence;
 }
 
 void SensorFusionBuzzer::playMelodyPGM(const char* sequence)
 {
+    /* Not implemented*/
+    (void) sequence;
 }
 
 /******************************************************************************

lib/HALSensorFusionTarget/SensorFusionProximitySensors.h

@@ -85,7 +85,7 @@ class SensorFusionProximitySensors : public IProximitySensors
      */
     uint8_t getNumSensors() const final
     {
-        return 1;
+        return 1U;
     }
 
     /**

lib/HALSim/IMU.h

@@ -167,7 +167,7 @@ class IMU : public IIMU
     void const getAccelerationValues(IMUData* accelerationValues);
 
     /**
-     * Get last raw Gyroscope values as an IMUData struct containing values in x, y and z in digits.
+     * Get last raw Gyro values as an IMUData struct containing values in x, y and z in digits.
      *
      * @param[in] turnRates  Pointer to IMUData struct where the raw turn Rates in digits in x, y and z
      * direction will be written into. The values can be converted into physical values in mrad/s via the multiplication

lib/HALTarget/IMU.h

@@ -147,7 +147,7 @@ class IMU : public IIMU
     const void getAccelerationValues(IMUData* accelerationValues);
 
     /**
-     * Get last raw Gyroscope values as an IMUData struct containing values in x, y and z in digits.
+     * Get last raw Gyro values as an IMUData struct containing values in x, y and z in digits.
      *
      * @param[in] turnRates  Pointer to IMUData struct where the raw turn Rates in digits in x, y and z
      * direction will be written into. The values can be converted into physical values in mrad/s via the multiplication

lib/HALTest/Board.h

@@ -210,7 +210,7 @@ class Board : public IBoard
     }
 
     /**
-     * Get IMU (=Inertial Measurement Unit) driver.
+     * Get IMU (Inertial Measurement Unit) driver.
      *
      * @return IMU driver
      */

lib/HALTest/Buzzer.cpp

@@ -60,14 +60,22 @@
 
 void Buzzer::playFrequency(uint16_t freq, uint16_t duration, uint8_t volume)
 {
+    /* Not implemented*/
+    (void) freq;
+    (void) duration;
+    (void) volume;
 }
 
 void Buzzer::playMelody(const char* sequence)
 {
+    /* Not implemented*/
+    (void) sequence;
 }
 
 void Buzzer::playMelodyPGM(const char* sequence)
 {
+    /* Not implemented*/
+    (void) sequence;
 }
 
 /******************************************************************************

lib/HALTest/IMU.h

@@ -44,6 +44,15 @@
  * Includes
  *****************************************************************************/
 #include "IIMU.h"
+
+/******************************************************************************
+ * Macros
+ *****************************************************************************/
+
+/******************************************************************************
+ * Types and Classes
+ *****************************************************************************/
+
 /** The IMU adapter.
  * IMU stands for Inertial Measurement Unit.
  */
@@ -70,7 +79,9 @@ class IMU : public IIMU
     /**
      * Enables all of the inertial sensors with a default configuration.
      */
-    void enableDefault(){};
+    void enableDefault()
+    {
+    };
 
     /**
      * 	Configures the sensors with settings optimized for turn sensing.
@@ -142,7 +153,7 @@ class IMU : public IIMU
     }
 
     /**
-     * Get last raw Gyroscope values as an IMUData struct containing values in x, y and z in digits.
+     * Get last raw Gyro values as an IMUData struct containing values in x, y and z in digits.
      *
      * @param[in] turnRates  Pointer to IMUData struct where the raw turn Rates in digits in x, y and z
      * direction will be written into. The values can be converted into physical values in mrad/s via the multiplication

lib/HALTest/ProximitySensors.h

@@ -85,7 +85,7 @@ class ProximitySensors : public IProximitySensors
      */
     uint8_t getNumSensors() const final
     {
-        return 1;
+        return 1U;
     }
 
     /**

platformio.ini

@@ -278,6 +278,7 @@ lib_deps =
 lib_ignore =
     APPConvoyLeader
     APPLineFollower
+    APPSensorFusion
 
 ; *****************************************************************************
 ; Remote control application specific HAL for target