Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release] rc/v0.0.2hotfix #8

Closed
wants to merge 3 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion DESCRIPTION
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
Package: dv.tables
Type: Package
Title: Table Modules
Version: 0.0.1
Version: 0.0.2
Authors@R: c(
person("Boehringer-Ingelheim Pharma GmbH & Co.KG", role = c("cph", "fnd")),
person(given = "Luis", family = "Moris Fernandez", role = c("aut", "cre"), email = "[email protected]")
Expand Down
4 changes: 4 additions & 0 deletions NEWS.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
# dv.tables 0.0.2

* Solves minor documentation issues

# dv.tables 0.0.1

* hierarchical_count_table.
14 changes: 7 additions & 7 deletions R/mod_hierarchical_count_table.R
Original file line number Diff line number Diff line change
Expand Up @@ -416,8 +416,7 @@ sort_wide_format_event_table_to_HTML <- function(d, on_cell_click = NULL) { # no
)
}

#' @describeIn mod_hierarchical_count_table UI
#' UI for the event count module
#' @describeIn mod_hierarchical_count_table UI for the event count module
#'
#' @param id `character(0)`
#' The ID for the event count module instance.
Expand Down Expand Up @@ -602,9 +601,9 @@ hierarchical_count_table_server <- function(
#' **This functionality is not ready yet** please
#' open an issue or contact the developers if you are interested in using it.
#'
#' @param server_wrapper_func `[function()]`
#'
#' A function that will be applied to the server
# @param server_wrapper_func `[function()]`
#
# A function that will be applied to the server
#'
#'
#' @keywords main
Expand All @@ -619,8 +618,9 @@ mod_hierarchical_count_table <- function(module_id,
default_group = NULL,
table_dataset_disp,
pop_dataset_disp,
receiver_id = NULL,
server_wrapper_func = identity) {
receiver_id = NULL
# ,server_wrapper_func = identity # nolint
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change prevents mock_app_hierarchical_count_table_mm() from working.

) {
if (!missing(table_dataset_name) && !missing(table_dataset_disp)) {
rlang::abort("`table_dataset_name` and `table_dataset_disp` cannot be used at the same time, use one or the other")
}
Expand Down
2 changes: 1 addition & 1 deletion man/compute_events_table.Rd

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion man/compute_order_events_table.Rd

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion man/mock_app_hierarchical_count_table.Rd

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion man/mock_app_hierarchical_count_table_mm.Rd

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

18 changes: 6 additions & 12 deletions man/mod_hierarchical_count_table.Rd

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion man/pivot_wide_format_events_table.Rd

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion man/sort_wide_format_event_table_to_HTML.Rd

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion man/sort_wider_formatter_events_table.Rd

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion vignettes/hierarchical_count_table.Rmd
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ adae_dataset <- pharmaverseadam::adae %>%
)

dv.manager::run_app(
data = list(dummy = list(adsl = adsl_dataset, adbm = adbm_dataset)),
data = list(dummy = list(adsl = adsl_dataset, adae = adae_dataset)),
module_list = list(
"AE Hierarchy Table" = dv.tables::mod_hierarchical_count_table(
module_id = "hierarchical_count_table",
Expand Down
Loading