Show last computed prompt when runtime is loading, and be more resilient to exception from rust #1325
+25
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ent to exception from rust
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
👍 Looks good to me! Reviewed everything up to 63e376d in 27 seconds
More details
- Looked at
125lines of code in4files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. typescript/playground-common/src/shared/baml-project-panel/atoms.ts:78
- Draft comment:
WasmDiagnosticErroris not defined in this scope. Ensure it is imported or defined before use. - Reason this comment was not posted:
Comment was not on a valid diff hunk.
Workflow ID: wflow_hUWlJco5LQqGvDIq
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important
Enhance prompt preview loading and error handling in the playground panel, with UI adjustments in
ClientGraphView.tsxandErrorFallback.tsx.prompt-preview-content.tsx, show last known prompt if runtime is loading and no new preview is available.atoms.ts, wrap runtime computation in atry-catchto handle exceptions from Rust gracefully.ClientGraphView.tsxheight from 400px to 350px.ErrorFallback.tsxto reload the page on error reset.ErrorFallback.tsx.This description was created by
for 63e376d. It will automatically update as commits are pushed.