Add permission error when user cannot write to /etc/nginx folder #62

poespas · 2024-12-30T06:26:10Z

Currently users get a very vague message when they run the nginx_config_reloader on an user that isn't able to write to /etc/nginx, this PR should solve this and add the check.

Before:

2024-12-30 06:25:19,553 nginx_config_reloader INFO     /data/web/nginx
2024-12-30 06:25:19,553 nginx_config_reloader DEBUG    Applying new config
2024-12-30 06:25:19,647 nginx_config_reloader ERROR    Installation of magento config failed

After:

2024-12-30 06:22:14,216 nginx_config_reloader INFO     /data/web/nginx
2024-12-30 06:22:14,216 nginx_config_reloader DEBUG    Applying new config
2024-12-30 06:22:14,229 nginx_config_reloader ERROR    No write permissions to main nginx config directory, please check your permissions.

tdgroot

LGTM, can you add a test to reflect the changes in _apply?

nginx_config_reloader/utils.py

Add permission error when user cannot write to /etc/nginx folder

ffe22f9

tdgroot approved these changes Dec 30, 2024

View reviewed changes

Fake main directory in tests, add unit test for checking permissions

0c814cb

tdgroot reviewed Dec 30, 2024

View reviewed changes

nginx_config_reloader/utils.py Outdated Show resolved Hide resolved

Remove unneeded import

97357f1

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add permission error when user cannot write to /etc/nginx folder #62

Add permission error when user cannot write to /etc/nginx folder #62

poespas commented Dec 30, 2024

tdgroot left a comment

Add permission error when user cannot write to /etc/nginx folder #62

Are you sure you want to change the base?

Add permission error when user cannot write to /etc/nginx folder #62

Conversation

poespas commented Dec 30, 2024

tdgroot left a comment

Choose a reason for hiding this comment