Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing src/middleware/admin #13

Open
wants to merge 22 commits into
base: f24
Choose a base branch
from
Open

Fixing src/middleware/admin #13

wants to merge 22 commits into from

Conversation

aadityanairaaq
Copy link

Fixed my file from Project 1 which was src/middleware/admin.

aadityanairaaq and others added 19 commits September 11, 2024 20:49
@aadityanairaaq
Update README.md to have Group Names
e47f182 
Resolves #1. Added the group names to the README file.
fixed topics/tools.js
24d4b74
fixed topics/tools.js
6633c02
@shgxshg
Merge pull request #21 from CMU-17313Q/ashwaqissue
13cca87 
 fixed topics/tools.js
@hkkubais
Fixing the nesting issues
01393b3
@aadityanairaaq
fixed src/middleware/admin.js
6cfd789
@aadityanairaaq
Revert "Fixing the nesting issues"
e6a31ec 
This reverts commit 01393b3.
fixRecursiveDepth
0e7e875
@Aya-Abdel-Hamid
Create bad_words.txt
c659d92
fixRecursiveDepth
850eeac
fixRecursiveDepth
af47dda
fixRecursiveDepth
510e329
fixRecursiveDepth
488603f
fixRecursiveDepth
671b22c
fixRecursiveDepth
a78bdf8
@aadityanairaaq
fixed-src/middleware/admin
d793f98
@Mohtelsayed
Merge branch 'f24' into fix-recursive-depth
670dbb7
@Mohtelsayed
Merge pull request #23 from CMU-17313Q/fix-recursive-depth
3d9c3d2 
Refactored code to fix nesting in src/user/delete.js
@aadityanairaaq
fixed-lint-errors-final
e231d53
@coveralls
Copy link

coveralls commented Sep 18, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 10944591148

Details

  • 51 of 73 (69.86%) changed or added relevant lines in 3 files are covered.
  • 5 unchanged lines in 4 files lost coverage.
  • Overall coverage decreased (-0.02%) to 82.665%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/topics/tools.js 18 21 85.71%
src/user/delete.js 2 5 40.0%
src/middleware/admin.js 31 47 65.96%
Files with Coverage Reduction New Missed Lines %
src/user/delete.js 1 83.93%
src/meta/errors.js 1 76.74%
src/groups/join.js 1 92.05%
src/middleware/admin.js 2 64.08%
Totals Coverage Status
Change from base Build 10701387427: -0.02%
Covered Lines: 22348
Relevant Lines: 25613
💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@aadityanairaaq @coveralls @shgxshg @hkkubais @Aya-Abdel-Hamid @Mohtelsayed