Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Working on the backend for the functionality of searching through documents - User Story 1 #34

Merged
merged 20 commits into from
Oct 20, 2024

Conversation

zanzoonh
Copy link

@zanzoonh zanzoonh commented Sep 26, 2024

Acceptance Criteria:
-User be able to search and find titles that match their search
-User be able to input keyword
-User be able to view discussion with titles matching the keyword

resolves #13

@zanzoonh zanzoonh added high effort high effort task back-end labels Sep 26, 2024
@zanzoonh zanzoonh added this to the Sprint 1 milestone Sep 26, 2024
@zanzoonh zanzoonh self-assigned this Sep 26, 2024
@zanzoonh
Copy link
Author

Issue was not completed by expected milestone. This was due to multiple reasons, including:

Underestimated difficulty of project
A lot of time was spent parsing through and trying to understand which files to look at and modify
The user search and the group search were implemented differently, which caused a lot of initial confusion on what to use as a template
Testing and coding to try and get user input was delayed due to dependencies between tasks

@coveralls
Copy link

coveralls commented Sep 26, 2024

Pull Request Test Coverage Report for Build 11428726510

Details

  • 9 of 52 (17.31%) changed or added relevant lines in 7 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.2%) to 82.579%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/topics/events.js 0 1 0.0%
src/controllers/topics.js 2 9 22.22%
src/api/categories.js 1 9 11.11%
src/controllers/categories.js 2 10 20.0%
src/api/posts.js 2 11 18.18%
src/categories/topics.js 1 11 9.09%
Totals Coverage Status
Change from base Build 11428714475: -0.2%
Covered Lines: 22381
Relevant Lines: 25671

💛 - Coveralls

…the branch to match origin/f24 Merge remote-tracking branch 'origin/adding-search-functionality' into adding-search-functionality
…gory.js and are found in public/src/client/users.js
…ories/topics as implemented search function is not returning the correct thing
@Hakaabi Hakaabi self-requested a review October 20, 2024 18:31
Copy link

@Hakaabi Hakaabi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done! This looks very well implemented.

@Hakaabi Hakaabi closed this Oct 20, 2024
@Hakaabi Hakaabi reopened this Oct 20, 2024
@zanzoonh
Copy link
Author

Issue was completed by Sprint 2.
Functionality matches search criteria, however an amendment was made to the issue. Topics which match the query are printed on the console rather than rendered, due to render method running but not causing any changes on the actual website.

@zanzoonh zanzoonh merged commit f998872 into f24 Oct 20, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
back-end high effort high effort task
Projects
None yet
3 participants