forked from CMU-17313Q/cmu-17313q-f24-nodebb-f24-NodeBB
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Testing anonymous posting feature for Topics and Posts-User Story 3 #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nodebb-f24-codehers into search-improving-sprint1
…ng a case for non-anonymous posts
Pull Request Test Coverage Report for Build 11365268078Details
💛 - Coveralls |
Hakaabi
added
documentation
Improvements or additions to documentation
low effort
low effort task
UserStory3
labels
Oct 16, 2024
Hakaabi
changed the title
Testing anonymous feature sprint2
Testing anonymous posting feature for Topics and Posts-User Story 3
Oct 16, 2024
zanzoonh
approved these changes
Oct 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
AlAnoud2003
reviewed
Oct 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This code seems crucial to your work. The code looks great!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Made a new branch off of the branch 'adding-anonymous-sprint1' to test the front and back-end implementation of the Anonymous feature.
Files modified and why:
1.test/api.js
Updated to handle the inclusion of 'isAnonymous' field in the schema and ensure alignment with the database changes.
2.test/posts.js
Added automated test cases to verify anonymous post creation, default non-anonymous posting, and the correct handling of the isAnonymous field in post specifications.
3.test/topics.js
Added automated test cases for anonymous topic creation, ensuring default topics are non-anonymous, and verifying the correct handling of the isAnonymous field in topic specifications.
These modifications were made to resolve this issue #33.