Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Testing Static Tool JShint #50

Open
wants to merge 9 commits into
base: f24
Choose a base branch
from
Open

Testing Static Tool JShint #50

wants to merge 9 commits into from

Conversation

Michaelli8899
Copy link

What?

  • Installed and tested the JShint static analysis tool on our team repository. Test file and artifact of terminal output screenshot can be found in the jshint-tool-artifacts directory.
  • Test includes js files from src and public

Why?

  • Testing and research of jshint tool. Will evaulate its usefulness in terms of catching our code mistakes.

Screenshots of Installation

screenshot of jshint version
image

jshint dependency added in package.json file
image

jshint dependency added in node_modules directory
image

Screenshot of Successful jshint Run

jshint terminal output
image

@coveralls
Copy link

Pull Request Test Coverage Report for Build 11453473361

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.02%) to 82.695%
Files with Coverage Reduction New Missed Lines %
src/meta/errors.js 1 76.74%
Totals Coverage Status
Change from base Build 11444961491: 0.02%
Covered Lines: 22378
Relevant Lines: 25637
💛 - Coveralls

@Michaelli8899 Michaelli8899 self-assigned this Oct 23, 2024
@Michaelli8899 Michaelli8899 added the enhancement New feature or request label Oct 23, 2024
@Michaelli8899 Michaelli8899 added this to the Project 3 milestone Oct 23, 2024
@a1inachen a1inachen added testing and removed enhancement New feature or request labels Oct 23, 2024
a1inachen
a1inachen approved these changes Oct 24, 2024
View reviewed changes
Copy link

@a1inachen a1inachen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

jshint set up looks good

bythehills
bythehills approved these changes Oct 24, 2024
View reviewed changes
Copy link

@bythehills bythehills left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test file and workflows looks good!

dominicteh1
dominicteh1 approved these changes Oct 24, 2024
View reviewed changes
Copy link

@dominicteh1 dominicteh1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

jshint looks good to me!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dominicteh1 dominicteh1 dominicteh1 approved these changes

@a1inachen a1inachen a1inachen approved these changes

@bythehills bythehills bythehills approved these changes

Assignees

@Michaelli8899 Michaelli8899

Labels
testing
Projects
None yet
Milestone
Project 3
Development

Successfully merging this pull request may close these issues.
5 participants
@Michaelli8899 @coveralls @bythehills @a1inachen @dominicteh1