Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compile executables from WW3 and update switches #73

Merged
merged 2 commits into from
Oct 17, 2023
Merged

Conversation

micaeljtoliveira
Copy link
Contributor

@micaeljtoliveira micaeljtoliveira commented Oct 9, 2023

Change CMake config to compile the following WW3 utilities:

  • ww3_strt
  • ww3_ounf
  • ww3_outf
  • ww3_outp
  • ww3_grid

Currently these are not installed. This will be changed in a future PR.

Also update the list of switches and update the build system to automatically take into account the switches when determining the WW3 source files.

@micaeljtoliveira
Copy link
Contributor Author

@ezhilsabareesh8 This PR adds the ww3_grid executable from WW3 to the OM3 compilation. Are there other executables that we would need?

@ezhilsabareesh8
Copy link
Contributor

ezhilsabareesh8 commented Oct 9, 2023

Hi @micaeljtoliveira, thanks for adding the ww3_grid executable to the OM3 compilation.

The standalone WW3 created the following executables,

gx_outf, ww3_bounc, ww3_gint, ww3_grid, ww3_multi, ww3_ounp, ww3_outp, ww3_prnc, ww3_strt, ww3_trck, ww3_uprstr, gx_outp, ww3_bound, ww3_grib, ww3_gspl, ww3_ounf, ww3_outf, ww3_prep, ww3_shel, ww3_systrk, ww3_trnc

But we need the following executables in OM3 for now:

ww3_strt, ww3_ounf, ww3_outf, ww3_outp, ww3_grid

Also, could you please change the source term switch from ST4 to ST6, so that it will be consistent with the Shou's config?

@micaeljtoliveira
Copy link
Contributor Author

@ezhilsabareesh8 Thanks for the list. This is now implemented.

@micaeljtoliveira micaeljtoliveira self-assigned this Oct 9, 2023
@micaeljtoliveira micaeljtoliveira added the ww3 Related to WW3 label Oct 9, 2023
@micaeljtoliveira micaeljtoliveira added this to the 0.3.x milestone Oct 9, 2023
@micaeljtoliveira micaeljtoliveira added enhancement New feature or request build system Build system labels Oct 10, 2023
@ezhilsabareesh8
Copy link
Contributor

Thanks @micaeljtoliveira for implementing this in the OM3 compilation. It looks good to me.

I am testing the switches locally and will update you once I finalize them.

… of source files. Update the list of swiches.
@micaeljtoliveira
Copy link
Contributor Author

@ezhilsabareesh8 I've just pushed an update to the build system to properly treat the switches. Could you give it a try?

@aekiss
Copy link
Contributor

aekiss commented Oct 17, 2023

This builds ok for me.

ww3_grid ww3_ounf ww3_outf ww3_outp ww3_strt are put in build/WW3/, but should they also be copied into bin with git hash tagging?

@micaeljtoliveira micaeljtoliveira changed the title Compile executables from WW3 Compile executables from WW3 and update switches Oct 17, 2023
Copy link
Contributor

@ezhilsabareesh8 ezhilsabareesh8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @micaeljtoliveira. These changes work for me and I was able to generate the WW3 input binary files with the executables in build/WW3

@micaeljtoliveira micaeljtoliveira merged commit 3965e25 into main Oct 17, 2023
2 checks passed
@micaeljtoliveira
Copy link
Contributor Author

ww3_grid ww3_ounf ww3_outf ww3_outp ww3_strt are put in build/WW3/, but should they also be copied into bin with git hash tagging?

@aekiss Sorry, I missed you comment before merging. I think for now we should leave them out. I'm in the process of changing the way how we install things on gadi. The idea will be to install everything through CMake and Spack.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build system Build system enhancement New feature or request ww3 Related to WW3
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants